Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not showing in Zeal #264

Closed
megies opened this issue Jan 28, 2015 · 3 comments
Closed

Icon not showing in Zeal #264

megies opened this issue Jan 28, 2015 · 3 comments
Milestone

Comments

@megies
Copy link

megies commented Jan 28, 2015

The Dash standard docs at http://kapeli.com/docsets#addingicon state that..

To set a custom icon for your docset,
simply add a "icon.png" file directly inside the docset bundle.

..but Zeal is not reading that file but as stated here is rather looking for a file Contents/Resources/Documents/icon.png. For that reason docsets created using doc2dash are not displayed with their icon in Zeal. (see hynek/doc2dash#35)

@megies megies changed the title Icon not shown showing in Zeal Icon not showing in Zeal Jan 28, 2015
trollixx added a commit that referenced this issue Jan 30, 2015
Decreases file I/O, since icons are kept in Docset now.
@megies
Copy link
Author

megies commented Jan 30, 2015

Quick squashing this issue! Another thing I noticed is that some docsets I've got from a Dash user have the file Info.plist with a lower case first letter "i": info.plist. These turn up with an empty docset name in the list of docsets in the left pane. That should also be a quick fix.. (I guess here:

info = DocsetInfo::fromPlist(dir.absoluteFilePath("Info.plist"));
)

@trollixx
Copy link
Member

The lower case info.plist should be work now (see 6970a77). I don't know docsets to test, so please verify that it works for you.

@trollixx trollixx modified the milestone: 0.1.0 Mar 15, 2015
trollixx pushed a commit that referenced this issue Jul 20, 2016
@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants