Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate_exists_and_valid_and_all_domains_included? is confusing #14

Open
troelskn opened this issue Aug 22, 2016 · 0 comments
Open

Comments

@troelskn
Copy link
Contributor

The method returns false or exits. From the name, one would assume it to return a boolean in all cases. Either the method should be renamed (To something like ensure_certificate_exists_and_valid_and_all_domains_included! perhaps) or it should return true instead of exit 2. The latter is probably better, but would require calling code to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant