Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selecting text in the chat panel #6706

Open
1 task done
bennetbo opened this issue Jan 25, 2024 · 0 comments
Open
1 task done

Support selecting text in the chat panel #6706

bennetbo opened this issue Jan 25, 2024 · 0 comments
Labels
chat Feedback for chat and messaging collaboration features collaboration The umbrella label for all collaboration features enhancement [core label]

Comments

@bennetbo
Copy link
Collaborator

bennetbo commented Jan 25, 2024

Check for existing issues

  • Completed

Describe the feature

It would be nice to be able to select and copy text inside the channel chat.

Here are my findings looking at the code:
Chat messages are essentially a markdown text block. Markdown is parsed into a gpui InteractiveText element, which is then rendered by RichText. We probably need to introduce some sort of selection mechanism inside InteractiveText.

If there is support for more complex markdown elements, e.g. #5386, text selection gets more complex. Essentially we would need to support selection over multiple different elements, which is then merged into a single text chunk when copying into clipboard. Also what about copying images?

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@bennetbo bennetbo added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jan 25, 2024
@JosephTLyons JosephTLyons added collaboration The umbrella label for all collaboration features chat Feedback for chat and messaging collaboration features and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat Feedback for chat and messaging collaboration features collaboration The umbrella label for all collaboration features enhancement [core label]
Projects
None yet
Development

No branches or pull requests

2 participants