-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for images in Markdown previews #16192
base: main
Are you sure you want to change the base?
Conversation
@dovakin0007 : Does it also work using the
|
no sir |
@dovakin0007 : What is displayed in case of the |
the alt text like zed gpui image doesn't have a way to display the alt text so for now I am displaying alt text directly |
Seems like there's some test failures as well. I'm going to mark this as draft for now, once things are ready to go feel free to mark it as ready :) As for your issues with the layout, perhaps you need to add some more styling rules on the |
I haven't looked at the PR in the detail, but I assume that we will run into the same issues I encountered in #10565.
Rendering images in separate lines feels like a good enough workaround for now, but 2. definitely feels like a blocker to me. |
yeah that should work. regarding the layout we have to render the image within text StyledText can't handle images for now |
yeah I am running into the same issues that you have mentioned. |
|
still img() doesn't return error for bad request |
I was able to render the image within markdown_preview_2.mp4text |
Support for inline elements in the text system is probably the better choice if the text and inline elements needs to wrap properly. Splitting the text and images into their own blocks is just avoiding the problem that will eventually be needed to be implemented. It may be fine for now. I've tried to implement it myself, but there are some changes and some decisions which I'm not sure what is best. I have had a issue up to track this #10916 |
Yeah I did try to do it but I wasn't on the right track so I scrapped it then for now implemented to render image as its separate own block rather than a part of interactive text yeah you are right once interactive text supports inline images this has to be changed |
Closes #13246
Release Notes:
added image preview for markdown
mark_down_img_preview.-.Made.with.Clipchamp.mp4
Release Notes: