markdown preview: Image support #10565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Works inside tables now, although the alignment is wrong (but that is an existing bug, see #11024) 
|
|
Closing this, the implementation seems to work fine, but the img element needs some better error handling first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering images inside the markdown preview.
Screen.Recording.2024-04-19.at.22.08.55.mov
Note: gpui does not support rendering inline elements inside a text, therefore this implementation inserts line breaks if a paragraph contains an image in between some text, which is not correct:
I think this behavior is still better than not supporting images at all and I believe most usages of images inside markdown are not "inline".
Release Notes: