Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data.directories setting from zeebe.cfg.toml #2789

Closed
jwulf opened this issue Jul 4, 2019 · 2 comments · Fixed by #5985
Closed

Remove data.directories setting from zeebe.cfg.toml #2789

jwulf opened this issue Jul 4, 2019 · 2 comments · Fixed by #5985
Assignees
@npepinpe
Labels
good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior

Comments

@jwulf
Copy link
Member

jwulf commented Jul 4, 2019

I propose that we remove the data.directories config option from zeebe.cfg.toml.

The data.directories config option is old school and hasn't been maintained or tested. According to @saig0 it is not respected across the board - in at least some places the parameter is ignored and only the first value is used.
pull bot pushed a commit to anniyanvr/zeebe that referenced this issue Oct 9, 2019
@dependabot-support
Merge camunda#2507
7b85c83 
2507: chore(deps): bump google.golang.org/grpc from 1.20.1 to 1.21.0 in /clients/go r=menski a=dependabot[bot]

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.20.1 to 1.21.0.
<details>
<summary>Release notes</summary>

*Sourced from [google.golang.org/grpc's releases](https://github.com/grpc/grpc-go/releases).*

> ## Release 1.21.0
> # New Features
> 
>  * balancer: provide parsed target through BuildOptions ([camunda#2803](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2803))
>  * grpclb: handle service config and switch to pickfirst ([camunda#2719](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2719))
>  * dns: rate limit DNS resolution requests ([camunda#2760](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2760))
>  * interceptor: new APIs for chaining client interceptors. ([camunda#2696](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2696))
>  * client: return helpful error message when wait-for-ready RPCs fail with timeout ([camunda#2777](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2777))
>    - Special Thanks: [@&camunda#8203;yuqitao](https://github.com/yuqitao)
> 
> # Bug Fixes
> 
>  * transport: fix a race that could lead to memory leaks ([camunda#2765](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2765))
>  * client: set balancer name correctly when using grpc.WithBalancerName() ([camunda#2778](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2778)) ([camunda#2802](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2802))
>    - Special Thanks: [@&camunda#8203;wjywbs](https://github.com/wjywbs)
> 
> # Documentation
> 
>  * docs: add note about retrying UNAVAILABLE ([camunda#2774](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2774))
> 
</details>
<details>
<summary>Commits</summary>

- [`869adfc`](grpc/grpc-go@869adfc) Change version to 1.21.0 ([camunda#2828](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2828))
- [`c2e0a6d`](grpc/grpc-go@c2e0a6d) Fix a typo. ([camunda#2826](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2826))
- [`7c03793`](grpc/grpc-go@7c03793) benchmark: refactor the benchmark code. ([camunda#2820](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2820))
- [`8655d47`](grpc/grpc-go@8655d47) credentials/alts: Add example of authz in ALTS ([camunda#2814](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2814))
- [`263405c`](grpc/grpc-go@263405c) docs: small docs fixed to WithDisableServiceConfig ([camunda#2819](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2819))
- [`4a199db`](grpc/grpc-go@4a199db) xds: split proto imports for message and service ([camunda#2812](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2812))
- [`ab90977`](grpc/grpc-go@ab90977) Fix using grpc.WithBalancerName("grpclb") explicitly ([camunda#2778](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2778)) ([camunda#2802](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2802))
- [`a0be99a`](grpc/grpc-go@a0be99a) xds: use BuildOptions.Target.endpoint string instead of deprecated cc.Target ...
- [`4748a04`](grpc/grpc-go@4748a04) balancer: provide parsed target through BuildOptions ([camunda#2803](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2803))
- [`39ed87f`](grpc/grpc-go@39ed87f) xds: report loads to traffic director ([camunda#2789](https://github-redirect.dependabot.com/grpc/grpc-go/issues/2789))
- Additional commits viewable in [compare view](grpc/grpc-go@v1.20.1...v1.21.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=google.golang.org/grpc&package-manager=dep&previous-version=1.20.1&new-version=1.21.0)](https://dependabot.com/compatibility-score.html?dependency-name=google.golang.org/grpc&package-manager=dep&previous-version=1.20.1&new-version=1.21.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
@Zelldon
Copy link
Member

Zelldon commented May 26, 2020

Not sure what you're referring to and why we should remove it 🤔 Could you elaborate on that? Is this still the case that you want to remove it?

@Zelldon Zelldon added the blocker/info Marks an issue as blocked, awaiting more information from the author label May 26, 2020
@npepinpe npepinpe added Impact: Tech Debt kind/feature Categorizes an issue or PR as a feature, i.e. new behavior and removed blocker/info Marks an issue as blocked, awaiting more information from the author labels Dec 8, 2020
@npepinpe
Copy link
Member

npepinpe commented Dec 8, 2020

From my point of view, this is mostly confusing for users. We only look at the first directory, so configuring multiple ones does nothing.

Please deprecate in favour of a new configuration option directory, but fallback to the directories if not specified by the user.

Note that I would still like to try specifying multiple directories, but I think the interface will be different - we can look into this at a later point.

@npepinpe npepinpe added the good first issue Marks an issue as simple enough for first time contributors label Dec 8, 2020
@npepinpe npepinpe self-assigned this Dec 8, 2020
@npepinpe npepinpe mentioned this issue Dec 8, 2020
Merged
8 tasks
@ghost ghost closed this as completed in #5985 Dec 14, 2020
@ghost ghost closed this as completed in c4ab987 Dec 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce single data directory configuration field camunda/camunda
4 participants
@npepinpe @jwulf @Zelldon @KerstinHebel