Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StandaloneBroker auto configures an Elasticsearch client #4403

Closed
npepinpe opened this issue Apr 28, 2020 · 0 comments · Fixed by #4495
Closed

StandaloneBroker auto configures an Elasticsearch client #4403

npepinpe opened this issue Apr 28, 2020 · 0 comments · Fixed by #4495
Assignees
@pihme
Labels
kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user

Comments

@npepinpe
Copy link
Member

Describe the bug

It seems Spring's auto configuration creates a high level REST Elasticsearch client, even when the exporter is not configured, resulting in a few threads being started for no reason and which are never closed. I don't think this is a huge problem, but definitely something to remove.

To Reproduce

  1. Start a standalone broker without Elasticsearch exporter
  2. Do a thread dump

You will see threads relating to a CloseableHttpAsyncClient, which is the client Elastic uses under the hood. To further confirm, you can add a breakpoint in Elasticsearch code where a client is created, and it will be triggered on start up.

Expected behavior

No client is created

Environment:

  • OS: Fedora 31
  • Zeebe Version: 0.24.0-SNAPSHOT (I imagine this affects any 0.23+)
  • Configuration: defaults
@npepinpe npepinpe added kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user labels Apr 28, 2020
@pihme pihme mentioned this issue May 11, 2020
Merged
@zeebe-bors zeebe-bors bot closed this as completed in 43e195a May 12, 2020
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
@renovate
chore(deps): update hashicorp/vault-action digest to d523bb0 (master) (…
bac3e7d 
…#4403)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pihme pihme

Labels
kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(broker): prevent auto config of elasticsearch client camunda/zeebe
4 participants
@npepinpe @menski @pihme @KerstinHebel