Refactor cluster event service

[deepthidevaki]

Description

• Use member properties to propagate subscription info instead of custom gossip
• EventService can now only broadcast. Methods for unicast and send are removed from the interface.

Related issues

closes #4154
closes #4307

Pull Request Checklist

• All commit messages match our commit message guidelines
• The submitting code follows our code style
• If submitting code, please run mvn clean install -DskipTests locally before committing

[Zelldon]

Cool 👍 much better I like it, just smaller things.

[deepthidevaki]

@Zelldon I found one issue with adding and removing local subscriptions. For every new subscription it was adding new handler to messaging service which might invoke the same subscribers multiple times for a single message. Similarly when closing we should unregister the handler when local subscribers are empty. I have fixed it and added more tests. Please have a look.

[Zelldon]

@Zelldon I found one issue with adding and removing local subscriptions. For every new subscription it was adding new handler to messaging service which might invoke the same subscribers multiple times for a single message. Similarly when closing we should unregister the handler when local subscribers are empty. I have fixed it and added more tests. Please have a look.

Thanks @deepthidevaki. Cool that you found more issues. I think the thing with the multiple handler calls can't happen since internal a map is used, which just replaces the handler. Furthermore if I remove your changes only the test which verifies that the other subscription is called fails. But still I think both tests makes sense, so thanks for that.

[deepthidevaki]

I think the thing with the multiple handler calls can't happen since internal a map is used, which just replaces the handler.

You are right. I mistook it for communication service where it keeps tracks of multiple handlers.

[deepthidevaki]

bors r+

[zeebe-bors]

Build failed

• continuous-integration/jenkins/branch

[deepthidevaki]

bors retry

[zeebe-bors]

Build succeeded

• continuous-integration/jenkins/branch