Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add also translation for the multiple-choice exercise #42

Closed
mircealungu opened this issue May 1, 2021 · 3 comments · Fixed by #47
Closed

add also translation for the multiple-choice exercise #42

mircealungu opened this issue May 1, 2021 · 3 comments · Fixed by #47
Assignees

Comments

@mircealungu
Copy link
Member

in this particular case i've got it after the second
try but I still don't know the word :))

image

alternative: make the whole text translatable as in the reader, and let me interact with it?

@beamb
Copy link
Contributor

beamb commented May 3, 2021

An easy fix could be to just add the translation once the correct answer is selected in the same way as the word to find is displayed in the find word in context exercise, i.e. in the place of "given of" in the image below you would have seen appear the translation of "opfordring" after clicking it.
image
This is just a quick fix -- could still explore having the text as in the reader if you would prefer. Let me know what solution I should go for.

@mircealungu
Copy link
Member Author

good idea! let's do this for now.
adding translations might be required for the other exercise too and it should be a different issue!

@beamb
Copy link
Contributor

beamb commented May 6, 2021

Great! Done in 174e819. I'll include a few more quick-fixes in that branch before making a pull request.

@beamb beamb closed this as completed May 6, 2021
@beamb beamb reopened this May 6, 2021
@beamb beamb mentioned this issue May 6, 2021
@beamb beamb linked a pull request May 7, 2021 that will close this issue
@beamb beamb closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants