Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level Makefile for plugin feature #15

Open
awelzel opened this issue Mar 7, 2023 · 2 comments
Open

Add top-level Makefile for plugin feature #15

awelzel opened this issue Mar 7, 2023 · 2 comments

Comments

@awelzel
Copy link
Contributor

awelzel commented Mar 7, 2023

I'm fairly used to build and install plugins via ./configure && make && make install, but the plugin feature doesn't seem to create a top-level Makefile.

Was that somehow on purpose or could we consider adding one?

@ckreibich
Copy link
Member

We certainly could, Arne. We used to have such a Makefile, and it's still in the plugin skeleton here. I never warmed up to that built-it target, and figured that since the build will normally be hidden behind zkg's build_command, it's fine to let go. Feel free to put one together if you'd prefer it.

@0xxon
Copy link
Member

0xxon commented Jul 21, 2023

FWIW - I am also in favor of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants