Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish doesn't start properly #1963

Closed
jkanche opened this issue Jun 29, 2017 · 9 comments
Closed

Fish doesn't start properly #1963

jkanche opened this issue Jun 29, 2017 · 9 comments

Comments

@jkanche
Copy link

jkanche commented Jun 29, 2017

sometimes, hyper doesn't load and won't initialize the prompt..

screenshot - Fish

I see this error when i open developer tools -

bundle.js:47 Uncaught TypeError: Cannot read property 'substr' of null

@timothyis
Copy link
Contributor

timothyis commented Jun 29, 2017

Hi, this looks like a duplicate of an really recent issue. Can you tell us if it's different than #1961?
If you could follow the issue template next time, we might be able to identify the issue much faster.

@timothyis timothyis changed the title Hyper doesn't show prompt Fish doesn't start properly Jun 29, 2017
@jkanche
Copy link
Author

jkanche commented Jun 30, 2017

I have no plugins installed but still see the error...

@timothyis
Copy link
Contributor

Right, the error is the same as the issue I linked, hence the assumption.
What operating system are you on? Which Hyper version are you on? Are you sure you have no plugins/themes? Hyper should be black by default and it looks like yours is themed.

@RobbieTheWagner
Copy link

Does it load after a few minutes? I'm seeing a startup time of several minutes all the sudden and I'm on fish too.

@jkanche
Copy link
Author

jkanche commented Jul 10, 2017

@codetheory

What operating system are you on?
Ubuntu 16.04

Which Hyper version are you on?
hyper 1.3.3

Are you sure you have no plugins/themes?
When i first posted the issue, i had a theme installed. but I removed all themes and plugins but the issue still persists

@rwwagner90

Does it load after a few minutes? I'm seeing a startup time of several minutes all the sudden and I'm on fish too.
No it doesn't i left it open for close to 30 min, nothing happened

@doughsay
Copy link

Hello! Happening to me too, on a fresh install of ubuntu + hyper (no plugins installed).

  • Ubuntu 17.04
  • installed fish through apt and set as my default shell (chsh)
  • installed hyper using latest .deb file 1.3.3
  • won't start, console shows above mentioned error (Uncaught TypeError: Cannot read property 'substr' of null)

@whitelynx
Copy link

whitelynx commented Aug 10, 2017

I'm also experiencing this, probably 75% of the times I start the app. Sometimes it works fine, other times it just freezes there and shows that error in the console.

I added some debugging console.log() calls before line 14037 of node_modules/hterm-umdjs/dist/index.js to see what the values involved were:

index.js:14037 this.foreground: ""
index.js:14038 this.defaultForeground: null
index.js:14039 colorToMakeFaint: null
index.js:463 Uncaught TypeError: Cannot read property 'substr' of null
    at Object.lib.colors.crackRGB (index.js:463)
    at Object.lib.colors.mix (index.js:445)
    at hterm.TextAttributes.syncColors (index.js:14040)
    at hterm.TextAttributes.setDefaults (index.js:13978)
    at hterm.VT.CSI.m (index.js:16324)
    at hterm.VT.dispatch (index.js:14853)
    at hterm.VT.parseCSI_ (index.js:14701)
    at hterm.VT.interpret (index.js:14612)
    at hterm.Terminal.interpret (index.js:11698)
    at __WEBPACK_IMPORTED_MODULE_2_runes___default.forEach.rune (hterm.js:134)

It seems like the foreground and defaultForeground properties of that particular hterm.TextAttributes instance aren't getting set before the syncColors method is called.

I also added a throw there if colorToMakeFaint is null, and was able to get a bit more of the stack:

Uncaught Error: colorToMakeFaint is null!
    at hterm.TextAttributes.syncColors (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:49056:13)
    at hterm.TextAttributes.setDefaults (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:48993:8)
    at hterm.VT.CSI.m (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:51342:9)
    at hterm.VT.dispatch (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:49871:11)
    at hterm.VT.parseCSI_ (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:49719:10)
    at hterm.VT.interpret (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:49630:27)
    at hterm.Terminal.interpret (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:46713:11)
    at __WEBPACK_IMPORTED_MODULE_2_runes___default.forEach.rune (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:16489:20)
    at Array.forEach (native)
    at hterm.Terminal.IO.component___WEBPACK_IMPORTED_MODULE_0_react___default.a.PureComponent.__WEBPACK_IMPORTED_MODULE_1_hterm_umdjs__.hterm.Terminal.IO.writeUTF8 (file:///home/whitelynx/Development/Other/hyperterm/app/dist/bundle.js:16487:57)

I was able to hack around the problem by adding the following before line 14037 of node_modules/hterm-umdjs/dist/index.js:

    if (colorToMakeFaint === null) {
      console.warn("colorToMakeFaint is null! Changing to black.");
      colorToMakeFaint = 'rgb(0, 0, 0)';
    }

Aside from that hack, I'm not sure how to proceed in debugging this past this point... any ideas?

@DanielRamosAcosta
Copy link

Problem still persists in 1.4.3

@Stanzilla
Copy link
Collaborator

Hey there, please try again with the new Hyper v2 release and open a new issue if the problem stills exists. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants