Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use electron's getPath() API to get the user's app data directory #2948

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Use electron's getPath() API to get the user's app data directory #2948

merged 1 commit into from
Feb 25, 2019

Conversation

Stanzilla
Copy link
Collaborator

@Stanzilla Stanzilla commented Apr 27, 2018 •
edited
Loading

Docs: https://github.com/electron/electron/blob/master/docs/api/app.md#appgetpathname
Closes: #1960
Fixes: #1944

A comment at https://github.com/zeit/hyper/pull/170/files#r83043056 suggests

(process.env.XDG_CONFIG_HOME !== undefined)
    ? join(process.env.XDG_CONFIG_HOME, 'hyper')
    : app.getPath('userData')

but I have no clue how relevant that still is. Detailed discussion at #1595

@Stanzilla Stanzilla added the 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper label Jun 24, 2018
xgdgsc
xgdgsc approved these changes Oct 22, 2018
View reviewed changes
Copy link

@xgdgsc xgdgsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the default path to use.

@xgdgsc xgdgsc mentioned this pull request Oct 22, 2018
Open
@xgdgsc
Copy link

xgdgsc commented Oct 22, 2018

also solves #137

@rauchg rauchg added the WIP label Dec 4, 2018
@juancampa
Copy link
Contributor

juancampa commented Jan 23, 2019 •
edited
Loading

+1 for using XDG_CONFIG_HOME on Mac as well. It's convenient for people that keep all their configs in a git repo.

@juancampa
Copy link
Contributor

Merging now, we can revisit the use of XDG_CONFIG_HOME later

@juancampa juancampa merged commit 80bb821 into vercel:canary Feb 25, 2019
@ppot ppot mentioned this pull request Mar 2, 2019
Merged
@Stanzilla Stanzilla deleted the 1960v2 branch October 11, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgdgsc xgdgsc xgdgsc approved these changes

@ppot ppot Awaiting requested review from ppot

@chabou chabou Awaiting requested review from chabou

@juancampa juancampa Awaiting requested review from juancampa

Assignees
No one assigned
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stanzilla @xgdgsc @juancampa @rauchg