-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfill documentation #4572
Comments
So to explain: The only time you'd need a polyfill is when you are pulling in an external dependency which is using methods that should be polyfilled in ie11/etc, this is what the |
Sure I will try and get one fo the team to do this some time next week. |
PR is up at #4601 |
…l#4601) Fixes vercel#4572 This PR intends to address vercel#4572 around documenting browser support and what needs polyfills. There are many outstanding issues on the tracker regarding browser support and polyfills. This may alleviate some of them.
btw. this is false claim this is fixed: #5783 Polyfills on native objects like |
I'm not sure what's false here, my comment says exactly what your issue describes.
|
Next.js by default with no external dependencies works fine in ie11. |
@timneutkens My fault, sorry! |
@timneutkens - our app is crashing in IE because of this line in nextjs router: b88addf#diff-49f9285928f23ee1231af5aa2534c70aL66 looks like includes is not polyfilled by default |
Feature request
Is your feature request related to a problem? Please describe.
Currently there is no clear guidelines on implementing polyfils for browsers. There exists examples to polyfill with
core-js
although there also exists examples to use.babelrc
with theenv
preset to support older browsers.There is allot of confusion and issues around this topic.
Describe the solution you'd like
A clear section in the documentation that describes using
.babelrc
and theenv
preset to polyfill older browsers.Additional context
We (ethical-jobs) would be happy to write up a PR / example to address this issue if people think its needed.
The text was updated successfully, but these errors were encountered: