Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove next-to-next-server babel plugin #6458

Merged
merged 4 commits into from
Feb 27, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 26, 2019

After discussion it was decided instead of rewriting next/config and next/head imports to next-server/config and next-server/head we should just allow importing them as next/config and next/head

Fixes: #6187

@timneutkens timneutkens merged commit 256970a into vercel:canary Feb 27, 2019
@chrisbolin
Copy link

thank you @ijjk! this fixes an ugly issue in our jest tests where we have to mock next-server/dynamic instead of next/server (it was also tough to debug the issue when we upgraded to next@8 😂)

really appreciate it!

@ijjk ijjk deleted the rm-next-to-next-server branch March 8, 2019 19:41
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publicRuntimeConfig undefined in test environment with Jest.
4 participants