Update with-apollo-auth example #8416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| buildDuration | 25.4s | 25.4s | -18ms |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.js | 17.9 kB | 17.9 kB | ✓ |
| main-HASH.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 190 kB | 190 kB | ✓ |
| commons.HASH.js gzip | 61.6 kB | 61.6 kB | ✓ |
| Overall change | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.2 kB | 16.2 kB | ✓ |
| main-HASH.module.js gzip | 6.28 kB | 6.28 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 171 kB | 171 kB | ✓ |
| commons.HASH.module.js gzip | 55.4 kB | 55.4 kB | ✓ |
| Overall change | ✓ |
Client Pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 12.1 kB | 12.1 kB | ✓ |
| _error.js gzip | 4.76 kB | 4.76 kB | ✓ |
| hooks.js | 1.06 kB | 1.06 kB | ✓ |
| hooks.js gzip | 600 B | 600 B | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 8.13 kB | 8.13 kB | ✓ |
| link.js gzip | 3.49 kB | 3.49 kB | ✓ |
| routerDirect.js | 429 B | 429 B | ✓ |
| routerDirect.js gzip | 292 B | 292 B | ✓ |
| withRouter.js | 439 B | 439 B | ✓ |
| withRouter.js gzip | 290 B | 290 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 10.6 kB | 10.6 kB | ✓ |
| _error.module.js gzip | 4.31 kB | 4.31 kB | ✓ |
| hooks.module.js | 596 B | 596 B | ✓ |
| hooks.module.js gzip | 354 B | 354 B | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 8.52 kB | 8.52 kB | ✓ |
| link.module.js gzip | 3.67 kB | 3.67 kB | ✓ |
| routerDirect.module.js | 417 B | 417 B | ✓ |
| routerDirect.module.js gzip | 292 B | 292 B | ✓ |
| withRouter.module.js | 427 B | 427 B | ✓ |
| withRouter.module.js gzip | 291 B | 291 B | ✓ |
| Overall change | ✓ |
Fetched pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| link | 2.8 kB | 2.8 kB | ✓ |
| link gzip | 849 B | 848 B | -1 B |
| index | 2.75 kB | 2.75 kB | ✓ |
| index gzip | 842 B | 841 B | -1 B |
| withRouter | 2.81 kB | 2.81 kB | ✓ |
| withRouter gzip | 837 B | 836 B | -1 B |
| Overall change | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| buildDuration | 26.3s | 26.7s | |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.js | 17.9 kB | 17.9 kB | ✓ |
| main-HASH.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 190 kB | 190 kB | ✓ |
| commons.HASH.js gzip | 61.6 kB | 61.6 kB | ✓ |
| Overall change | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.2 kB | 16.2 kB | ✓ |
| main-HASH.module.js gzip | 6.28 kB | 6.28 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 171 kB | 171 kB | ✓ |
| commons.HASH.module.js gzip | 55.4 kB | 55.4 kB | ✓ |
| Overall change | ✓ |
Client Pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 12.1 kB | 12.1 kB | ✓ |
| _error.js gzip | 4.76 kB | 4.76 kB | ✓ |
| hooks.js | 1.06 kB | 1.06 kB | ✓ |
| hooks.js gzip | 600 B | 600 B | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 8.13 kB | 8.13 kB | ✓ |
| link.js gzip | 3.49 kB | 3.49 kB | ✓ |
| routerDirect.js | 429 B | 429 B | ✓ |
| routerDirect.js gzip | 292 B | 292 B | ✓ |
| withRouter.js | 439 B | 439 B | ✓ |
| withRouter.js gzip | 290 B | 290 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 10.6 kB | 10.6 kB | ✓ |
| _error.module.js gzip | 4.31 kB | 4.31 kB | ✓ |
| hooks.module.js | 596 B | 596 B | ✓ |
| hooks.module.js gzip | 354 B | 354 B | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 8.52 kB | 8.52 kB | ✓ |
| link.module.js gzip | 3.67 kB | 3.67 kB | ✓ |
| routerDirect.module.js | 417 B | 417 B | ✓ |
| routerDirect.module.js gzip | 292 B | 292 B | ✓ |
| withRouter.module.js | 427 B | 427 B | ✓ |
| withRouter.module.js gzip | 291 B | 291 B | ✓ |
| Overall change | ✓ |
Serverless bundles
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _error.js | 247 kB | 247 kB | ✓ |
| _error.js gzip | 66.3 kB | 66.3 kB | ✓ |
| hooks.html | 2.87 kB | 2.87 kB | ✓ |
| hooks.html gzip | 865 B | 864 B | -1 B |
| index.js | 248 kB | 248 kB | ✓ |
| index.js gzip | 66.6 kB | 66.6 kB | ✓ |
| link.js | 255 kB | 255 kB | ✓ |
| link.js gzip | 68.8 kB | 68.8 kB | ✓ |
| routerDirect.js | 248 kB | 248 kB | ✓ |
| routerDirect.js gzip | 66.5 kB | 66.5 kB | ✓ |
| withRouter.js | 248 kB | 248 kB | ✓ |
| withRouter.js gzip | 66.6 kB | 66.6 kB | |
| Overall change | ✓ |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
| <input | ||
| name='password' | ||
| placeholder='Password' | ||
| ref={node => { |
There was a problem hiding this comment.
It will be great to use useRef() inside React Hooks.
There was a problem hiding this comment.
That's a good point. Didn't notice it. I will add it as soon as i can
| @@ -9,6 +9,8 @@ | |||
| "start": "next start" | |||
| }, | |||
| "dependencies": { | |||
| "@apollo/react-hooks": "3.0.1", | |||
There was a problem hiding this comment.
Did you miss ^ or it is on purpose?
There was a problem hiding this comment.
I just installed via yarn add @apollo/react-hooks. Didn't do anything special with it. And in my opinion sometimes it's better to lock concrete version of the package, especially for examples. So it will be safe for end-user to install deps.
There was a problem hiding this comment.
You right, but if we did not lock it (especially for the examples that developers use it regularly) users may report some issues with it, so we can make sure it works overtime.
There was a problem hiding this comment.
I locked it. End user will always get version 3.0.1 and nothing else, but anyway we can go with carets
| import withApollo from '../lib/withApollo' | ||
|
|
||
| class MyApp extends App { | ||
| static displayName = 'MyApp' |
There was a problem hiding this comment.
What's the point of the displayName variable? it does not use in _app.js
There was a problem hiding this comment.
It is needed for better devtools experience. Check how react devtools shows it:
There was a problem hiding this comment.
Nice, so do you agree to write a single line comment for it? like the comment that you mention above.
|
@alieslamifard thank u for your time reviewing me |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| buildDuration | 24.2s | 24.4s | |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.js | 17.9 kB | 17.9 kB | ✓ |
| main-HASH.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 190 kB | 190 kB | ✓ |
| commons.HASH.js gzip | 61.6 kB | 61.6 kB | ✓ |
| Overall change | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.2 kB | 16.2 kB | ✓ |
| main-HASH.module.js gzip | 6.28 kB | 6.28 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 171 kB | 171 kB | ✓ |
| commons.HASH.module.js gzip | 55.4 kB | 55.4 kB | ✓ |
| Overall change | ✓ |
Client Pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 12.1 kB | 12.1 kB | ✓ |
| _error.js gzip | 4.76 kB | 4.76 kB | ✓ |
| hooks.js | 1.06 kB | 1.06 kB | ✓ |
| hooks.js gzip | 600 B | 600 B | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 8.13 kB | 8.13 kB | ✓ |
| link.js gzip | 3.49 kB | 3.49 kB | ✓ |
| routerDirect.js | 429 B | 429 B | ✓ |
| routerDirect.js gzip | 292 B | 292 B | ✓ |
| withRouter.js | 439 B | 439 B | ✓ |
| withRouter.js gzip | 290 B | 290 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 10.6 kB | 10.6 kB | ✓ |
| _error.module.js gzip | 4.31 kB | 4.31 kB | ✓ |
| hooks.module.js | 596 B | 596 B | ✓ |
| hooks.module.js gzip | 354 B | 354 B | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 8.52 kB | 8.52 kB | ✓ |
| link.module.js gzip | 3.67 kB | 3.67 kB | ✓ |
| routerDirect.module.js | 417 B | 417 B | ✓ |
| routerDirect.module.js gzip | 292 B | 292 B | ✓ |
| withRouter.module.js | 427 B | 427 B | ✓ |
| withRouter.module.js gzip | 291 B | 291 B | ✓ |
| Overall change | ✓ |
Fetched pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| link | 2.8 kB | 2.8 kB | ✓ |
| link gzip | 848 B | 850 B | |
| index | 2.75 kB | 2.75 kB | ✓ |
| index gzip | 841 B | 842 B | |
| withRouter | 2.81 kB | 2.81 kB | ✓ |
| withRouter gzip | 836 B | 838 B | |
| Overall change | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| buildDuration | 26.2s | 26.4s | |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.js | 17.9 kB | 17.9 kB | ✓ |
| main-HASH.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 190 kB | 190 kB | ✓ |
| commons.HASH.js gzip | 61.6 kB | 61.6 kB | ✓ |
| Overall change | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.2 kB | 16.2 kB | ✓ |
| main-HASH.module.js gzip | 6.28 kB | 6.28 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 171 kB | 171 kB | ✓ |
| commons.HASH.module.js gzip | 55.4 kB | 55.4 kB | ✓ |
| Overall change | ✓ |
Client Pages
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 12.1 kB | 12.1 kB | ✓ |
| _error.js gzip | 4.76 kB | 4.76 kB | ✓ |
| hooks.js | 1.06 kB | 1.06 kB | ✓ |
| hooks.js gzip | 600 B | 600 B | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 8.13 kB | 8.13 kB | ✓ |
| link.js gzip | 3.49 kB | 3.49 kB | ✓ |
| routerDirect.js | 429 B | 429 B | ✓ |
| routerDirect.js gzip | 292 B | 292 B | ✓ |
| withRouter.js | 439 B | 439 B | ✓ |
| withRouter.js gzip | 290 B | 290 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 10.6 kB | 10.6 kB | ✓ |
| _error.module.js gzip | 4.31 kB | 4.31 kB | ✓ |
| hooks.module.js | 596 B | 596 B | ✓ |
| hooks.module.js gzip | 354 B | 354 B | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 8.52 kB | 8.52 kB | ✓ |
| link.module.js gzip | 3.67 kB | 3.67 kB | ✓ |
| routerDirect.module.js | 417 B | 417 B | ✓ |
| routerDirect.module.js gzip | 292 B | 292 B | ✓ |
| withRouter.module.js | 427 B | 427 B | ✓ |
| withRouter.module.js gzip | 291 B | 291 B | ✓ |
| Overall change | ✓ |
Serverless bundles
| zeit/next.js canary | tabomors/next.js update-with-apollo-auth | Change | |
|---|---|---|---|
| _error.js | 247 kB | 247 kB | ✓ |
| _error.js gzip | 66.3 kB | 66.3 kB | |
| hooks.html | 2.87 kB | 2.87 kB | ✓ |
| hooks.html gzip | 864 B | 866 B | |
| index.js | 248 kB | 248 kB | ✓ |
| index.js gzip | 66.6 kB | 66.6 kB | |
| link.js | 255 kB | 255 kB | ✓ |
| link.js gzip | 68.8 kB | 68.8 kB | |
| routerDirect.js | 248 kB | 248 kB | ✓ |
| routerDirect.js gzip | 66.5 kB | 66.5 kB | |
| withRouter.js | 248 kB | 248 kB | ✓ |
| withRouter.js gzip | 66.6 kB | 66.6 kB | |
| Overall change | ✓ |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Timer
added
Documentation
examples
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Fetched pages
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Serverless bundles
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to solve this issue #8375
Please check the discussion.
What i did:
withApolloHOCreact-apollowith@apollo/react-hooksand@apollo/react-ssr