Use argument in init.sh to avoid usage of sudo #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chralt98
reviewed
Jun 23, 2023
Co-authored-by: Chralt <chralt.developer@gmail.com>
Chralt98
approved these changes
Jun 23, 2023
sea212
added
s:accepted
Merged
sea212
added a commit
that referenced
this pull request
Jul 5, 2023
* Update weights (#1025) * Update crate and runtime version (#1026) * Use argument in init.sh to avoid usage of sudo (#1028) * Update scripts/init.sh Co-authored-by: Chralt <chralt.developer@gmail.com> * Update script documentation --------- Co-authored-by: Chralt <chralt.developer@gmail.com> * Fix name collision (#1029) * Use updated Rococo bootnodes (#1030) --------- Co-authored-by: Chralt <chralt.developer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Instead of relying on the (seemingly unreliable)
/.dockerenvfile to determine a docker build requirement withinscripts/init.sh, an optional argument is now used.What important points should reviewers know?
This PR is a result of a failed workflow.
Is there something left for follow-up PRs?
No.
What alternative implementations were considered?
None.
Are there relevant PRs or issues?
A previous PR attempted to fix this already. While the solution worked until now, it seems it is not 100% reliable.
References
None.