Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated Rococo bootnodes #1030

Merged
merged 2 commits into from Jun 23, 2023
Merged

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Jun 23, 2023

What does it do?

As Chris discovered, the Battery Station node does not connect to the Rococo relay chain. This is caused by the node using a Cumulus version which uses polkadot-service that contains deprecated bootnodes that are not active anymore.

This PR uses a patched polkadot-service crate that utilized the most recent Rococo bootnodes.

What important points should reviewers know?

None.

Is there something left for follow-up PRs?

  • Next maintenance PRs have to check whether a patch is required again or not.

What alternative implementations were considered?

None.

Are there relevant PRs or issues?

References

None.

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Jun 23, 2023
@sea212 sea212 added this to the v0.3.9 milestone Jun 23, 2023
@sea212 sea212 self-assigned this Jun 23, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jun 23, 2023
@sea212 sea212 requested a review from Chralt98 June 23, 2023 16:25
@sea212 sea212 changed the base branch from release-v0.3.9 to main June 23, 2023 16:39
@sea212 sea212 changed the base branch from main to release-v0.3.9 June 23, 2023 16:40
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jun 23, 2023
@sea212 sea212 merged commit a322411 into release-v0.3.9 Jun 23, 2023
3 checks passed
@sea212 sea212 deleted the sea212-patch-rococo-bootnodes branch June 23, 2023 17:51
@sea212 sea212 mentioned this pull request Jul 3, 2023
sea212 added a commit that referenced this pull request Jul 5, 2023
* Update weights (#1025)

* Update crate and runtime version (#1026)

* Use argument in init.sh to avoid usage of sudo (#1028)

* Update scripts/init.sh

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update script documentation

---------

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Fix name collision (#1029)

* Use updated Rococo bootnodes (#1030)

---------

Co-authored-by: Chralt <chralt.developer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants