Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark orderbook-v1 #105

Merged
merged 6 commits into from
Apr 30, 2021
Merged

Benchmark orderbook-v1 #105

merged 6 commits into from
Apr 30, 2021

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Apr 28, 2021 •
edited
Loading

Issue: #99
Solution: Implement benchmarks and add weights for every dispatchable function in the orderbook-v1 pallet.
Progress:

Benchmarks

  • cancel_order
  • fill_order
  • make_order

Weights

  • cancel_order
  • fill_order
  • make_order

@sea212 sea212 changed the title [WIP] Benchmark orderbook-v1 Benchmark orderbook-v1 Apr 29, 2021
@sea212 sea212 marked this pull request as ready for review April 29, 2021 10:38
@sea212 sea212 requested review from c410-f3r and lsaether and removed request for c410-f3r April 29, 2021 12:10
@sea212 sea212 force-pushed the sea212-benchmark-orderbook-weights branch from 67ffa3e to b42161f Compare April 29, 2021 19:18
lsaether
lsaether approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@lsaether lsaether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to note that asks require more reads / writes than bids do

@c410-f3r
Copy link
Contributor

sp_std::marker::PhantomData and core::marker::PhantomData are the same but it doesn't matter. In any case, sp_std is required by the benchmark macros IIRC

@sea212 sea212 merged commit f8b614a into main Apr 30, 2021
@sea212 sea212 deleted the sea212-benchmark-orderbook-weights branch April 30, 2021 09:13
c410-f3r pushed a commit to c410-f3r/zeitgeist that referenced this pull request Sep 14, 2021
@sea212 @c410-f3r
Benchmark orderbook-v1 (zeitgeistpm#105)
e56668f 
* Add benchmark scaffold

* Add benchmark: make_order

* Add weight: make_order

* Update benchmark & weight: make_order

* Add benchmark & weights: cancel_order

* Add benchmark & weight: fill_order

This commit also fixes zeitgeistpm#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c410-f3r c410-f3r c410-f3r approved these changes

@lsaether lsaether lsaether approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sea212 @c410-f3r @lsaether