Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parachain-staking benchmarks #1066

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Aug 4, 2023

What does it do?

Two errors hindered the successful execution of the benchmarks within pallet-parachain-staking.

  1. MinSelectedCandiates = 8 for battery station runtime, which is used in dev parachain, is less than num_selected_candidates in dev parachain's GenesisConfig. However, the condition num_selected_candidates >= MinSelectedCandidates must be met.
  2. Fix runtime-benchmarks moonbeam-foundation/moonbeam#2227

This PR fixes 1. and updated dependencies from the Moonbeam branch that incorporates 2.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Aug 4, 2023
@sea212 sea212 added this to the v0.3.11 milestone Aug 4, 2023
@sea212 sea212 requested a review from Chralt98 August 4, 2023 12:48
@sea212 sea212 self-assigned this Aug 4, 2023
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obvious question: I think you did initially use num_selected_candidates = 1, because if we use cargo build and then ./target/debug/zeitgeist --dev --tmp we are usually having only one node instance running. So hopefully the dev configuration still produces blocks.

@sea212
Copy link
Member Author

sea212 commented Aug 5, 2023

The obvious question: I think you did initially use num_selected_candidates = 1, because if we use cargo build and then ./target/debug/zeitgeist --dev --tmp we are usually having only one node instance running. So hopefully the dev configuration still produces blocks.

We use the standalone client for one node environments, this parameter only affects the parachain client though.

@sea212 sea212 merged commit caea6d7 into release-v0.3.11 Aug 5, 2023
11 of 12 checks passed
@sea212 sea212 deleted the sea212-fix-parachain-staking-benchmarks branch August 5, 2023 08:21
sea212 added a commit that referenced this pull request Aug 8, 2023
* Update versions (#1063)

* Fix try-runtime makefile targets (#1065)

* Fix parachain-staking benchmarks (#1066)

* Fix fee tests (#1070)

* Update weights (#1068)
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants