Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fee tests #1070

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fix fee tests #1070

merged 3 commits into from
Aug 7, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Aug 6, 2023 •
edited

What does it do?

  • Adjusts the default fee per second in the xcm transfers tests, as those changed due to an updated default_fee_per_second (inherited from updated ExtrinsicBaseWeight.
  • Removes unnecessary checks.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Aug 6, 2023
@sea212 sea212 added this to the v0.3.11 milestone Aug 6, 2023
@sea212 sea212 self-assigned this Aug 6, 2023
@sea212 sea212 changed the base branch from main to release-v0.3.11 August 6, 2023 13:09
@sea212 sea212 changed the title Sea212 fix fee tests Fix fee tests Aug 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (release-v0.3.11@caea6d7). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                 @@
##             release-v0.3.11    #1070   +/-   ##
==================================================
  Coverage                   ?   93.50%           
==================================================
  Files                      ?       92           
  Lines                      ?    21581           
  Branches                   ?        0           
==================================================
  Hits                       ?    20179           
  Misses                     ?     1402           
  Partials                   ?        0
Flag Coverage Δ
tests 93.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Aug 6, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 6, 2023
@sea212 sea212 requested a review from Chralt98 August 6, 2023 23:33
@sea212 sea212 added s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on labels Aug 7, 2023
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 7, 2023
@sea212 sea212 merged commit 5f2b4ad into release-v0.3.11 Aug 7, 2023
29 of 30 checks passed
@sea212 sea212 deleted the sea212-fix-fee-tests branch August 7, 2023 07:59
sea212 added a commit that referenced this pull request Aug 8, 2023
@sea212
Merge release-v0.3.11 into main (#1071)
7a2e5cb 
* Update versions (#1063)

* Fix try-runtime makefile targets (#1065)

* Fix parachain-staking benchmarks (#1066)

* Fix fee tests (#1070)

* Update weights (#1068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chralt98 Chralt98 Chralt98 approved these changes

Assignees

@sea212 sea212

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sea212 @codecov-commenter @Chralt98