Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions to 0.2.1 #382

Merged
merged 10 commits into from Nov 29, 2021
Merged

Update versions to 0.2.1 #382

merged 10 commits into from Nov 29, 2021

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Nov 25, 2021

Depends on #381

@sea212 sea212 added the s:blocked The pull requests awaits resolution of dependencies (state what it depends on) label Nov 25, 2021
@sea212 sea212 self-assigned this Nov 25, 2021
@sea212
Copy link
Member Author

sea212 commented Nov 25, 2021

Blocked until #381 is merged.

@sea212 sea212 mentioned this pull request Nov 28, 2021
Merged
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:blocked The pull requests awaits resolution of dependencies (state what it depends on) labels Nov 29, 2021
lsaether
lsaether approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@lsaether lsaether left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you base the commits on main so the diff is cleaner? (I accidentally merged the other PR without this 😄 )

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Nov 29, 2021
@sea212 sea212 merged commit 28987c0 into main Nov 29, 2021
@sea212 sea212 deleted the sea212-update-versions branch November 29, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsaether lsaether lsaether approved these changes

Assignees

@sea212 sea212

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sea212 @lsaether