Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register remaining benchmarks #383

Merged
merged 15 commits into from Nov 29, 2021
Merged

Register remaining benchmarks #383

merged 15 commits into from Nov 29, 2021

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Nov 26, 2021

Preparation for #377

Before we are able to benchmark every pallet (including external pallets), we have to register their benchmarking logic in our runtime.
The frame pallets work out-of-the-box, the orml pallet unfortunately require a custom benchmarking environment and benchmarking logic.

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Nov 26, 2021
@sea212 sea212 self-assigned this Nov 26, 2021
@sea212 sea212 added s:blocked The pull requests awaits resolution of dependencies (state what it depends on) and removed s:in-progress The pull requests is currently being worked on labels Nov 26, 2021
@sea212
Copy link
Member Author

sea212 commented Nov 26, 2021 •
edited

Blocked until #382 is merged.

@sea212 sea212 marked this pull request as ready for review November 26, 2021 15:44
This was referenced Nov 26, 2021
Closed
Merged
@sea212
Copy link
Member Author

sea212 commented Nov 29, 2021

Rebasing onto main soon.

@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:blocked The pull requests awaits resolution of dependencies (state what it depends on) labels Nov 29, 2021
@sea212
Implement TransactionCallFilter struct
74b43ca
@sea212
Complete txfilter implementation
31c81f9
@sea212
Add txfilter feature and prettify code
e85c04c
@sea212
Add initialization constants & rename key functions
d88d5fb
@sea212
Modify generic_genesis() to allow more control over endowed accounts
cf02a0a
@sea212
Configure initial keys
38a44df
@sea212
Cargo fmt
d1743fd
@sea212
Include frame pallets in benchmarking subsystem
9fe3a2c 
ORML modules stand out a bit, since they don't offer a runtime-benchmarks feature and use a custom benchmarking crate. The benchmarking logic has to be manually implemented for any orml crate :(
@sea212
Add frame and orml weight templates
00acc1b
@sea212
Add orml currencies & tokens benchmark logic from Acala
a52e32c
@sea212
Add and modify utils.rs (benchmarking utilities)
924acc8
@sea212
Adjust orml weight template, tokens benchmark and add weights
5e3fcc7
@sea212
Adjust orml_currencies benchmark logic & add custom weights
ba9617d
@sea212
Adjust frame benchmark template, benchmark pallet_balances & add weights
196a968
@sea212
Satisfy clippy
607012b
@sea212 sea212 force-pushed the sea212-register-remaining-benchmarks branch from cd4974e to 607012b Compare November 29, 2021 18:32
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Nov 29, 2021
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Nov 29, 2021
@sea212 sea212 merged commit 1c3cdd3 into main Nov 29, 2021
@sea212 sea212 deleted the sea212-register-remaining-benchmarks branch November 29, 2021 19:53
This was referenced Nov 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsaether lsaether lsaether approved these changes

Assignees

@sea212 sea212

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sea212 @lsaether