Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compile time warnings. #147

Closed
Kenix3 opened this issue May 18, 2021 · 3 comments
Closed

Reduce compile time warnings. #147

Kenix3 opened this issue May 18, 2021 · 3 comments

Comments

@Kenix3
Copy link
Contributor

Kenix3 commented May 18, 2021

We should fix up the code to remove as many compiler warnings as possible while still keeping OK.

Further, we should implement something like this PR for OOT until we are ready to elevate warnings to errors.
zeldaret/oot#768

@EllipticEllipsis
Copy link
Contributor

I think we should perhaps be a little less stringent than this: in OoT there are several pretty horrible coding mistakes that cause warnings, that it would be possible to fix while maintaining OK, but OoT prefers not to since they are genuine mistakes in the original, not our own.

@Kenix3
Copy link
Contributor Author

Kenix3 commented May 18, 2021

I think we should perhaps be a little less stringent than this: in OoT there are several pretty horrible coding mistakes that cause warnings, that it would be possible to fix while maintaining OK, but OoT prefers not to since they are genuine mistakes in the original, not our own.

These would probably not be OK? Either way, if it's OK, how can you prove the original code had the mistake?

For MM I would rather fix the defect, as long as it's OK.

@Kenix3
Copy link
Contributor Author

Kenix3 commented May 19, 2021

#152

@Kenix3 Kenix3 closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants