-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce compile time warnings. #147
Comments
I think we should perhaps be a little less stringent than this: in OoT there are several pretty horrible coding mistakes that cause warnings, that it would be possible to fix while maintaining OK, but OoT prefers not to since they are genuine mistakes in the original, not our own. |
These would probably not be OK? Either way, if it's OK, how can you prove the original code had the mistake? For MM I would rather fix the defect, as long as it's OK. |
We should fix up the code to remove as many compiler warnings as possible while still keeping OK.
Further, we should implement something like this PR for OOT until we are ready to elevate warnings to errors.
zeldaret/oot#768
The text was updated successfully, but these errors were encountered: