Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boolcast uses from code #369

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Conversation

hatal175
Copy link
Contributor

No description provided.

@hatal175
Copy link
Contributor Author

The build got this warning:
CMake Error at CMakeLists.txt:13 (set_project_warnings):
Unknown CMake command "set_project_warnings".

help?

@hytopoulos
Copy link
Collaborator

Try pushing a empty commit

@HookedBehemoth
Copy link
Contributor

The buildscript for the tooling relied on a cmake script from a remote repository that has been moved to a different a while back.
https://github.com/cpp-best-practices/cpp_starter_project/commits/a85fe3d4aec4fedf40342b73f5fabf7c752cefc5/cmake/CompilerWarnings.cmake

I'd suggest hard coding a commit that has the file here https://github.com/cpp-best-practices/project_options/blob/main/src/CompilerWarnings.cmake

@HookedBehemoth
Copy link
Contributor

I guess they recently deleted the master branch?

@Ibot02 Ibot02 mentioned this pull request Feb 10, 2022
@hytopoulos
Copy link
Collaborator

Looks like you missed a macro in eyegore.c

@hatal175
Copy link
Contributor Author

New code was merged. Will fix.

@hytopoulos hytopoulos merged commit faaf9c7 into zeldaret:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants