Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools failing to build #370

Closed
Ibot02 opened this issue Feb 10, 2022 · 2 comments · Fixed by #372
Closed

Tools failing to build #370

Ibot02 opened this issue Feb 10, 2022 · 2 comments · Fixed by #372

Comments

@Ibot02
Copy link
Collaborator

Ibot02 commented Feb 10, 2022

Behemoth pointed out the reason in #369
Tagging @Henny022p since they probably have the best overview of the cmake build stuff.
@Henny022p
Copy link
Collaborator

I'd just switch to using https://github.com/cpp-best-practices/project_options.

@Henny022p
Copy link
Collaborator

Well, they require a higher cmake version that what we have available

Henny022p added a commit to Henny022p/tmc that referenced this issue Feb 10, 2022
@Henny022p
switch to using cpp-best-practices/project_options for compiler warnings
f912b65 
suboptimal solution due to us being limited to cmake 3.13 on jenkins
fixes zeldaret#370
@Henny022p Henny022p mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to using cpp-best-practices/project_options for compiler warnings Henny022p/tmc
2 participants
@Ibot02 @Henny022p