You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
based on http://geojson.org/geojson-spec.html#polygon GeoPolygon lacks 1 more level of coordinates to make it an "array of LinearRing coordinate arrays" and compatible with the spec.
I rectified it with a quick fix (amcvega@8f0c4c0) in the GeoPolygon.hs. Tried making the tests pass again but got stumped by the bigAssFeatureCollectionJSON test.
Great work! This package is a life-saver.
The text was updated successfully, but these errors were encountered:
I've got a fix in the referenced pull request, which I will merge in tomorrow if you dont see any problems with it :)
The LinearRing enforces the length of the "LinearRings" the spec describes. Later I will probably modify it to also compare the first and last element of the vector in the JSON Value and double check they are "equal", though I'm a bit hesitant to do that since the most common use cases is going to involve Doubles.
In any case, it wont affect the interface and when/if i do that it can be a minor point release.
I'll probably also do something similar with the Line objects to ensure that they are at least 2 elements long, further down the track.
based on http://geojson.org/geojson-spec.html#polygon GeoPolygon lacks 1 more level of coordinates to make it an "array of LinearRing coordinate arrays" and compatible with the spec.
I rectified it with a quick fix (amcvega@8f0c4c0) in the GeoPolygon.hs. Tried making the tests pass again but got stumped by the bigAssFeatureCollectionJSON test.
Great work! This package is a life-saver.
The text was updated successfully, but these errors were encountered: