StrykerRepairSearchProblem: getSuccessors(FixCandidate s) throws null pointer exception when PRVO is involved

[nmaguirre]

When attempting to repair a program, getSuccessors throws a null pointer exception. PRVO is involved.

To reproduce the bug, enable PRV* in MuJavaAPI, and run test

programRepairWithSimpleIncorrectMethodDepthTwo()

from test class BasicProgramRepairTest.

For the moment, I'm commenting PRV* so that all tests pass.

[saiema]

Error appears to be in line 693 of mujava.op.PRVO

boolean onlyPublic = t.getPackage() == null || !(t.getPackage().contains(getSelfType().getPackage()));

getSelfType().getPackage() must be null
t.getPackage() can't be null (otherwise the right part of the expression wouldn't be evaluated)

Posible solution:

boolean bothPackageAreNull = t.getPackage() == null && getSelfType().getPackage() == null;
boolean tPackageIsNull = t.getPackage() == null;
boolean thisPackageIsNull = getSelfType().getPackage() == null;
boolean tPackageContainsThisPackage = !thisPackageIsNull && t.getPackage().contains(getSelfType().getPackage());
boolean onlyPublic = !bothPackageAreNull && (tPackageIsNull || !tPackageContainsThisPackage);

I can make this change on muJava++ project but I don't know how to bring those changes to stryker

[saiema]

fixed in 35a49d0