Desktop mod #4
Desktop mod #4
Conversation
There was a problem hiding this comment.
Hello @zemola,
You did a terrific work!!! 👏 🚀
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🔥 🔥 🔥
- You used media queries correctly!
- Your PR looks professional
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Happy coding and stay awesome! 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can always find me on slack!
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| </header> | ||
|
|
||
| <section class="main-body"> | ||
| <div class="intro"> | ||
| <h1>I’m Azeem | ||
| <h1 class="intro-text">I’m Azeem |
There was a problem hiding this comment.
- Let's add the correct styles to the title in the headline section. Remember that the idea is to make it look as similar to the template.
Yours:
Template:
Some of your issues with your fonts might be the link to fonts.google.com you're using. Try going back there and in the selection page for your font, remember to add all of the family styles. Check my image for reference. Or follow this tutorial for more insight in fonts.google.com.
There was a problem hiding this comment.
No LinkedIn icon error from my end, kindly confirm it's not your system.
Thank you
| @@ -35,7 +42,7 @@ <h1>I’m Azeem | |||
| </div> | |||
| <div class="footer"> | |||
| <div class="connect-link"> | |||
| <h4 href="">Let's Connect</h4> | |||
| <a href="#">LET'S CONNECT</a> | |||
| </div> | |||
| <ul class="icons"> | |||
| <li class="gitHub"><img src="image\github.svg" alt=" shows gitHub icon"></li> | |||
There was a problem hiding this comment.
- Let's fix your linkedin icon, it seems like the link might be broken.
There was a problem hiding this comment.
Thank you for your honest feedback
There was a problem hiding this comment.
Hi @zemola ✋,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Kindly fix the requested changes and you good to go✨✔✔
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <ul class="icons"> | ||
| <li class="gitHub"><img src="image\github.svg" alt=" shows gitHub icon"></li> |
There was a problem hiding this comment.
- As pointed out by the first reviewer the link to the LinkedIn icon seems broken. I'd suggest that if you are using the
live serverextension kindly usecopy pathby right-clicking on your HTML file instead to view your page✌
There was a problem hiding this comment.
I need someone to confirm this for me before asking for review again cause I only have one chance.
Can you be of help?
There was a problem hiding this comment.
Changes Required ♻️
Hello @zemola
Good job so far 🎉 . There are still a few changes ♻️ you need to make in order to proceed. Please check my inline comments to learn more. Please implement the changes made by previous reviewers too.
Happy Coding.
There was a problem hiding this comment.
STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾
Hi @zemola,
Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾
Optional suggestions
Check the comments under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| </div> | ||
| <ul class="icons"> | ||
| <li class="gitHub"><img src="image\github.svg" alt=" shows gitHub icon"></li> | ||
| <li class="linkedin"><img src="image\linkedIn.svg" alt="show linkedIn icon"></li> | ||
| <li class="linkedin"><img src="image\linkedin.svg" alt="show linkedIn icon"></li> |
There was a problem hiding this comment.
- [OPTIONAL] As requested by the previous code reviewer, the link to the linkedin icon is broken, please kindly fix that.
Did the desktop version of my portfolio, made use of Media query for responsive web design, setting braking point at 992.