Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Throw Grenade context menu action #132

Merged
merged 13 commits into from Sep 13, 2021
Merged

Add Throw Grenade context menu action #132

merged 13 commits into from Sep 13, 2021

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Aug 24, 2019

When merged this pull request will:

Image

throw_grenades_2

@mharis001 mharis001 added the feature Adds a new feature label Aug 24, 2019
@mharis001 mharis001 added this to the 1.5.0 milestone Aug 24, 2019
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently a bit iffy.

Here you can see a unit is asked to throw but they just stop and move on

If the whole squad is selected and then you ask them to throw, they will ignore you completely and not even stop (only observed when asked to throw an IR grenade).

Sometimes when running and the whole squad is selected and after their first command they'll do nothing and at some point, they'll react if you ask again.

@mharis001
Copy link
Member Author

I can't reproduce the issue in the gif. I can't find a problem specific to the IR grenade, working for me. Was there anything specific (behaviour change) applied to that group?

For the second, are you sure that the position was in range. I added a notification for when not all units are in range of the position but, the units should always stop/react since this disables their PATH.

@CreepPork
Copy link
Member

No idea if I was in the range as it is not displayed clearly for the user. Have you tried running different mods with it and seeing if that makes a change?

@mharis001 mharis001 modified the milestones: 1.5.0, 1.6.0 Oct 6, 2019
@mharis001 mharis001 modified the milestones: 1.6.0, 1.7.0 Nov 7, 2019
@mharis001 mharis001 modified the milestones: 1.7.0, 1.8.0 Feb 21, 2020
@CreepPork CreepPork mentioned this pull request May 8, 2020
@mharis001 mharis001 modified the milestones: 1.8.0, 1.9.0 May 19, 2020
@CreepPork
Copy link
Member

Does this integrate with #371 or what happens with this PR?

@mharis001 mharis001 modified the milestones: 1.9.0, 1.10.0 Aug 9, 2020
@mharis001 mharis001 modified the milestones: 1.10.0, 1.11.0 Jan 15, 2021
@CreepPork
Copy link
Member

Does this integrate with #371 or what happens with this PR?

?

@mharis001
Copy link
Member Author

Not really sure. Both don't handle in-combat units that well at the moment.

@mharis001 mharis001 modified the milestones: 1.11.0, Backlog Mar 5, 2021
@mharis001
Copy link
Member Author

Now works more consistently for units in combat. Also, updated to use new commands/features such as hash maps.

Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good.

@mharis001 mharis001 merged commit b9264f6 into master Sep 13, 2021
@mharis001 mharis001 deleted the throw-grenades branch September 13, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement Achilles "AI Throw Smoke" Keybind Feature Request: Keybind to throw a frag grenade from a unit
4 participants