What is the recommended way to initialize the C.Env map?

[mfzl]

Is it designed to check if the Env map is nil first before assigning values in middle-ware?

[mfzl]

Just for an example, something like below fails, because Env is not initialized. Is this not how it was intended to use?

r := web.New()
r.Use(func(c *web.C, h http.Handler) http.Handler {
    c.Env["test"] = r.URL.Path
    return handler
})

r.Get("/", func(c web.C, w http.ResponseWriter, req *http.Request) {
    log.Println(c.Env["test"])
})

[zenazn]

Yeah, the current behavior is by design—you're supposed to check c.Env for nil before using it. It was originally a (misguided?) attempt to avoid the extra map allocation if it's not needed.

I think the right place to enforce that c.Env is non-nil is probably as a middleware at the top of the stack. I'd be happy to provide a reference implementation of this in goji's middleware stdlib if you like.

[mfzl]

I think explicit initialization goes well with the philosophy of the framework. Though I think it's worth mentioning it somewhere and have an example demonstrating the case.

👍 for middleware.

Thanks

[zenazn]

I pushed a standard middleware for this, along with a bit of documentation about the behavior. I probably owe you a bit more documentation than that, but that's going to go on the back burner for now (it probably belongs in a "how do you even middleware?" section of some document)

[mfzl]

After checking the middleware package I now see why I got it wrong in the first place. Anyway thanks for the EnvInit middleware.