Fix "PHP Warning: Illegal string offset" in two files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 88 `$_SESSION['shipping']['title'] = 'free_free';` raised this warning: [12-Apr-2013] PHP Warning: Illegal string offset 'title' in /shop/includes/modules/pages/checkout_shipping/header_php.php on line 88 Since line 87 `$_SESSION['shipping'] = 'free_free';` it seems like removal is warranted.
Fixed PHP Warning raised by evaluating `$_SESSION['shipping']['id']`
|
Assigned SDLC issue number CHANGE-592 against v160 |
|
Hi, Just wanted to update this. At the moment we will not be merging your pull request. That's not to say that there is no merit in your code. However there is a larger problem regarding the use of the $_SESSION['shipping'} array. Specifically that sometimes it is addressed as a string and other times as an array. While your commit addresses one aspect of that, we want to look at addressing the more global problem. |
|
Thanks for the feedback and I completely agree. Glad you're addressing the source of the problem instead of the symptom. |
zcwilt
pushed a commit
that referenced
this pull request
Jul 1, 2015
zcwilt
pushed a commit
that referenced
this pull request
Feb 18, 2016
This was referenced Aug 20, 2016
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Aug 29, 2019
If a plugin is removed from a store and the use of the plugin has been authorized for a non-superuser admin-profile, admins using that profile can no longer sign in. For instance, if the Sales Report was previously installed, the following PHP issues are logged on the admin login attempt: ``` [26-Aug-2019 07:42:36 America/New_York] Request URI: /myadmin/index.php, IP address: 127.0.0.1 #1 constant() called at [C:\xampp\htdocs\zc156c\myadmin\includes\functions\admin_access.php:837] #2 zen_get_admin_menu_for_user() called at [C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php:56] #3 require(C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php) called at [C:\xampp\htdocs\zc156c\myadmin\includes\header.php:257] zencart#4 require(C:\xampp\htdocs\zc156c\myadmin\includes\header.php) called at [C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php:225] zencart#5 require(C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php) called at [C:\xampp\htdocs\zc156c\myadmin\index.php:26] --> PHP Warning: constant(): Couldn't find constant BOX_REPORTS_SALES_REPORT in C:\xampp\htdocs\zc156c\myadmin\includes\functions\admin_access.php on line 837. [26-Aug-2019 07:42:36 America/New_York] Request URI: /myadmin/index.php, IP address: 127.0.0.1 #1 constant() called at [C:\xampp\htdocs\zc156c\myadmin\includes\functions\admin_access.php:838] #2 zen_get_admin_menu_for_user() called at [C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php:56] #3 require(C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php) called at [C:\xampp\htdocs\zc156c\myadmin\includes\header.php:257] zencart#4 require(C:\xampp\htdocs\zc156c\myadmin\includes\header.php) called at [C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php:225] zencart#5 require(C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php) called at [C:\xampp\htdocs\zc156c\myadmin\index.php:26] --> PHP Warning: constant(): Couldn't find constant FILENAME_STATS_SALES_REPORT in C:\xampp\htdocs\zc156c\myadmin\includes\functions\admin_access.php on line 838. [26-Aug-2019 07:42:36 America/New_York] Request URI: /myadmin/index.php, IP address: 127.0.0.1 #1 trigger_error() called at [C:\xampp\htdocs\zc156c\myadmin\includes\functions\html_output.php:16] #2 zen_href_link() called at [C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php:61] #3 require(C:\xampp\htdocs\zc156c\myadmin\includes\header_navigation.php) called at [C:\xampp\htdocs\zc156c\myadmin\includes\header.php:257] zencart#4 require(C:\xampp\htdocs\zc156c\myadmin\includes\header.php) called at [C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php:225] zencart#5 require(C:\xampp\htdocs\zc156c\myadmin\index_dashboard.php) called at [C:\xampp\htdocs\zc156c\myadmin\index.php:26] --> PHP Fatal error: zen_href_link(, , SSL), unable to determine the page link. in C:\xampp\htdocs\zc156c\myadmin\includes\functions\html_output.php on line 16. ``` This PR updates the `zen_get_admin_menu_for_user` function to ensure that an admin-page's 'pageName' and 'main_page' constants are _defined_ before attempting to use them as constants. Note that this doesn't address the underlying issue where those now-unused page-definitions are still in the database.
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Sep 12, 2019
Running PHP 7.1.32 and seeing logs similar to the following when a customer goes to download their virtual products. Noting that `floor` returns a float, so casting the return to an int corrects the issue. ``` [11-Sep-2019 19:04:11 UTC] Request URI: /index.php?main_page=download&order=1234&id=1759, IP address: xx.xx.xx.xx #1 zcObserverDownloadsViaRedirect->generateRandomName() called at [/home/store/mysite/includes/classes/observers/auto.downloads_via_redirect.php:72] #2 zcObserverDownloadsViaRedirect->updateNotifyDownloadReadyToRedirect() called at [/home/store/mysite/includes/classes/class.base.php:103] #3 base->notify() called at [/home/store/mysite/includes/modules/pages/download/header_php.php:212] zencart#4 require(/home/store/mysite/includes/modules/pages/download/header_php.php) called at [/home/store/mysite/index.php:36] --> PHP Notice: String offset cast occurred in /home/store/mysite/includes/classes/observers/auto.downloads_via_redirect.php on line 100. ```
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Sep 12, 2019
Seeing debug logs similar to: ``` [29-Aug-2019 19:49:25 UTC] Request URI: /ipn_main_handler.php?type=ec&markflow=1&clearSess=1&stage=final, IP address: xx.xx.xx.xx #1 paypalwpp->ec_step1() called at [/home/site/mysite/ipn_main_handler.php:76] --> PHP Notice: Undefined index: PAYMENTACTION in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 1606. [29-Aug-2019 19:49:25 UTC] Request URI: /ipn_main_handler.php?type=ec&markflow=1&clearSess=1&stage=final, IP address: xx.xx.xx.xx #1 paypalwpp->ec_step1() called at [/home/site/mysite/ipn_main_handler.php:76] --> PHP Notice: Undefined index: entry_telephone in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 1660. [29-Aug-2019 19:49:25 UTC] Request URI: /ipn_main_handler.php?type=ec&markflow=1&clearSess=1&stage=final, IP address: xx.xx.xx.xx #1 paypalwpp->ec_step1() called at [/home/site/mysite/ipn_main_handler.php:76] --> PHP Notice: Undefined index: L_ERRORCODE0 in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 1701. [29-Aug-2019 19:49:25 UTC] Request URI: /ipn_main_handler.php?type=ec&markflow=1&clearSess=1&stage=final, IP address: xx.xx.xx.xx #1 paypalwpp->ec_step1() called at [/home/site/mysite/ipn_main_handler.php:76] --> PHP Notice: Undefined index: L_ERRORCODE0 in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 1726. [29-Aug-2019 19:50:21 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->before_process() called at [/home/site/mysite/includes/classes/payment.php:246] #2 payment->before_process() called at [/home/site/mysite/includes/modules/checkout_process.php:92] #3 require(/home/site/mysite/includes/modules/checkout_process.php) called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:14] zencart#4 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PAYMENTACTION in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 327. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->_errorHandler() called at [/home/site/mysite/includes/modules/payment/paypalwpp.php:431] #2 paypalwpp->before_process() called at [/home/site/mysite/includes/classes/payment.php:246] #3 payment->before_process() called at [/home/site/mysite/includes/modules/checkout_process.php:92] zencart#4 require(/home/site/mysite/includes/modules/checkout_process.php) called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:14] zencart#5 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PAYMENTSTATUS in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 2881. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->before_process() called at [/home/site/mysite/includes/classes/payment.php:246] #2 payment->before_process() called at [/home/site/mysite/includes/modules/checkout_process.php:92] #3 require(/home/site/mysite/includes/modules/checkout_process.php) called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:14] zencart#4 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PNREF in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 438. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->before_process() called at [/home/site/mysite/includes/classes/payment.php:246] #2 payment->before_process() called at [/home/site/mysite/includes/modules/checkout_process.php:92] #3 require(/home/site/mysite/includes/modules/checkout_process.php) called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:14] zencart#4 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined property: paypalwpp::$response in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 466. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->after_process() called at [/home/site/mysite/includes/classes/payment.php:254] #2 payment->after_process() called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:17] #3 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PPREF in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 513. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->after_process() called at [/home/site/mysite/includes/classes/payment.php:254] #2 payment->after_process() called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:17] #3 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: ship_country in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 522. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->after_process() called at [/home/site/mysite/includes/classes/payment.php:254] #2 payment->after_process() called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:17] #3 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PAYMENTINFO_0_SETTLEAMT in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 537. [29-Aug-2019 19:50:24 UTC] Request URI: /index.php?main_page=checkout_process, IP address: xx.xx.xx.xx #1 paypalwpp->after_process() called at [/home/site/mysite/includes/classes/payment.php:254] #2 payment->after_process() called at [/home/site/mysite/includes/modules/pages/checkout_process/header_php.php:17] #3 require(/home/site/mysite/includes/modules/pages/checkout_process/header_php.php) called at [/home/site/mysite/index.php:36] --> PHP Notice: Undefined index: PAYMENTINFO_0_EXCHANGERATE in /home/site/mysite/includes/modules/payment/paypalwpp.php on line 539. ```
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Nov 16, 2019
Seeing logs similar to: ``` [16-Nov-2019 14:22:49 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] #2 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] #3 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: countries_name in C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php on line 86. [16-Nov-2019 14:22:49 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] #2 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] #3 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: countries_iso_code_2 in C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php on line 86. [16-Nov-2019 14:22:49 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] #2 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] #3 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: countries_iso_code_3 in C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php on line 86. [16-Nov-2019 14:22:50 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 zen_get_country_name() called at [C:\xampp\htdocs\mystore\includes\modules\shipping\usps.php:1298] #2 usps->_getQuote() called at [C:\xampp\htdocs\mystore\includes\modules\shipping\usps.php:285] #3 usps->quote() called at [C:\xampp\htdocs\mystore\includes\classes\shipping.php:168] zencart#4 shipping->quote() called at [C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php:129] zencart#5 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] zencart#6 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] zencart#7 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: countries_name in C:\xampp\htdocs\mystore\includes\functions\functions_lookups.php on line 63. [16-Nov-2019 14:22:50 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 usps->quote() called at [C:\xampp\htdocs\mystore\includes\classes\shipping.php:168] #2 shipping->quote() called at [C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php:129] #3 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] zencart#4 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] zencart#5 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: Service in C:\xampp\htdocs\mystore\includes\modules\shipping\usps.php on line 378. [16-Nov-2019 14:22:50 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: 127.0.0.1 #1 zen_get_country_name() called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_modules_shipping_estimator.php:98] #2 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_modules_shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php:261] #3 require(C:\xampp\htdocs\mystore\includes\modules\shipping_estimator.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php:211] zencart#4 require(C:\xampp\htdocs\mystore\includes\templates\temp\templates\tpl_shopping_cart_default.php) called at [C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php:190] zencart#5 require(C:\xampp\htdocs\mystore\includes\templates\temp\common\tpl_main_page.php) called at [C:\xampp\htdocs\mystore\index.php:97] --> PHP Notice: Undefined index: countries_name in C:\xampp\htdocs\mystore\includes\functions\functions_lookups.php on line 63. ``` ... if the "Update" button is clicked but the countries' dropdown still contains "Please select...".
This was referenced Apr 8, 2020
This was referenced May 26, 2022
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Jun 19, 2022
With the recently merged addition of `configurationValidation::sanitizeEmailNullOK`, I'm met with a couple of issues:
1. A Fatal PHP error:
```
[19-Jun-2022 06:40:04 America/New_York] PHP Fatal error: Uncaught Error: Using $this when not in object context in C:\xampp\htdocs\zc158\hoisT-PYL-teAch\includes\classes\configurationValidation.php:23
Stack trace:
#0 [internal function]: configurationValidation::sanitizeEmailNullOK('0')
#1 C:\xampp\htdocs\zc158\hoisT-PYL-teAch\includes\functions\configuration_checks.php(53): filter_var('0', 1024, Array)
#2 C:\xampp\htdocs\zc158\hoisT-PYL-teAch\configuration.php(22): zen_validate_configuration_entry('0', '{"error":"TEXT_...')
#3 C:\xampp\htdocs\zc158\hoisT-PYL-teAch\index.php(11): require('C:\\xampp\\htdocs...')
zencart#4 {main}
thrown in C:\xampp\htdocs\zc158\hoisT-PYL-teAch\includes\classes\configurationValidation.php on line 23
```
2. When that's corrected, an optional email address entered as `0` is accepted as valid
This was referenced Jun 29, 2022
Closed
Merged
lat9
added a commit
that referenced
this pull request
Oct 7, 2023
If a customer's not logged in, getting a PHP warning: ``` [07-Oct-2023 13:15:31 America/New_York] Request URI: /zc200/, IP address: 127.0.0.1, Language id 1 #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') --> PHP Warning: Undefined array key "customer_id" in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11. [07-Oct-2023 13:15:31 America/New_York] PHP Fatal error: Uncaught TypeError: zen_user_has_gv_account(): Argument #1 ($customer_id) must be of type int, null given, called in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11 and defined in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php:54 Stack trace: #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_user_has_gv_account(NULL) #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php on line 54 ```
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Oct 15, 2023
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument zencart#4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') zencart#4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
drbyte
pushed a commit
that referenced
this pull request
Oct 25, 2023
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument #4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
lat9
added a commit
to lat9/zencart
that referenced
this pull request
Dec 9, 2023
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() #2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') zencart#4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') zencart#5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
drbyte
pushed a commit
that referenced
this pull request
Dec 9, 2023
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() #2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') #4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') #5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument zencart#4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') zencart#2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') zencart#3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') zencart#4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() zencart#2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') zencart#3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') zencart#4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') zencart#5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
zcwilt
added a commit
to zcwilt/zencart
that referenced
this pull request
Mar 7, 2024
# This is the 1st commit message: cart refactor # This is the commit message zencart#2: using db # This is the commit message zencart#3: initial commit # This is the commit message zencart#4: cart # This is the commit message zencart#5: cart # This is the commit message zencart#6: cart refactoring # This is the commit message zencart#7: refactor cart # This is the commit message zencart#8: more cart work and testing updates # This is the commit message zencart#9: testing # This is the commit message zencart#10: updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offering solutions for
PHP Warning: Illegal string offset 'title' in /shop/includes/modules/pages/checkout_shipping/header_php.php on line 88
and
PHP Warning: Illegal string offset 'id' in includes/templates/template_default/templates/tpl_checkout_shipping_default.php