Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Travis build #17

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix failing Travis build #17

merged 1 commit into from
Jul 2, 2018

Conversation

nick-f
Copy link
Contributor

@nick-f nick-f commented Jul 2, 2018

Description

Travis build was failing due to outdated versions of Rubocop, Brakeman, and flay. Bumping gem versions to fix this.

Steps to reproduce

Before

bundle exec rake wwtd
Ignoring: branches, cache, dist, language, sudo
START env: TASK='spec'
bundle install --quiet
bundle exec rake $TASK
/Users/nfreeland/.rbenv/versions/2.2.10/bin/ruby -I/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/lib:/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-support-3.5.0/lib /Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
..........................................................................................F.FF

Failures:

  1) Abbreviato Brakecheck brakeman is up to date
     Failure/Error: expect(Brakecheck.compare(gem_name)).to include(true)

       expected [false, "Local version 4.2.1 of brakeman is not the latest version 4.3.1"] to include true
       Diff:
       @@ -1,2 +1,2 @@
       -[true]
       +[false, "Local version 4.2.1 of brakeman is not the latest version 4.3.1"]
     # ./spec/abbreviato/abbreviato_spec.rb:352:in `block (4 levels) in <top (required)>'

  2) Abbreviato Brakecheck rubocop is up to date
     Failure/Error: expect(Brakecheck.compare(gem_name)).to include(true)

       expected [false, "Local version 0.54.0 of rubocop is not the latest version 0.57.2"] to include true
       Diff:
       @@ -1,2 +1,2 @@
       -[true]
       +[false, "Local version 0.54.0 of rubocop is not the latest version 0.57.2"]
     # ./spec/abbreviato/abbreviato_spec.rb:352:in `block (4 levels) in <top (required)>'

  3) Abbreviato Brakecheck flay is up to date
     Failure/Error: expect(Brakecheck.compare(gem_name)).to include(true)

       expected [false, "Local version 2.10.0 of flay is not the latest version 2.12.0"] to include true
       Diff:
       @@ -1,2 +1,2 @@
       -[true]
       +[false, "Local version 2.10.0 of flay is not the latest version 2.12.0"]
     # ./spec/abbreviato/abbreviato_spec.rb:352:in `block (4 levels) in <top (required)>'

Finished in 0.7574 seconds (files took 0.24055 seconds to load)
94 examples, 3 failures

Failed examples:

rspec './spec/abbreviato/abbreviato_spec.rb[1:18:2]' # Abbreviato Brakecheck brakeman is up to date
rspec './spec/abbreviato/abbreviato_spec.rb[1:18:4]' # Abbreviato Brakecheck rubocop is up to date
rspec './spec/abbreviato/abbreviato_spec.rb[1:18:5]' # Abbreviato Brakecheck flay is up to date

/Users/nfreeland/.rbenv/versions/2.2.10/bin/ruby -I/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/lib:/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-support-3.5.0/lib /Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed
FAILURE env: TASK='spec'

After

bundle exec rake wwtd
Ignoring: branches, cache, dist, language, sudo
START env: TASK='spec'
bundle install --quiet
bundle exec rake $TASK
/Users/nfreeland/.rbenv/versions/2.2.10/bin/ruby -I/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/lib:/Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-support-3.5.0/lib /Users/nfreeland/.rbenv/versions/2.2.10/lib/ruby/gems/2.2.0/gems/rspec-core-3.5.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
..............................................................................................

Finished in 1.2 seconds (files took 0.24238 seconds to load)
94 examples, 0 failures

SUCCESS env: TASK='spec'

Travis build was failing due to outdated versions of Rubocop, Brakeman,
and flay. Bumping gem versions to fix this.
Copy link
Contributor

@iamliamnorton iamliamnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-f nick-f merged commit 44d3881 into master Jul 2, 2018
@nick-f nick-f deleted the nickf/fix-failing-build branch July 2, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants