Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation formats #16

Closed
tmcinerney opened this issue Dec 21, 2013 · 7 comments
Closed

Translation formats #16

tmcinerney opened this issue Dec 21, 2013 · 7 comments

Comments

@tmcinerney
Copy link
Contributor

We shouldn't add to the complication for app developers by introducing them to the title, value pair structure of translations, for the same reason I just closed zendesk/zendesk_apps_tools#32 (comment).

I think we should simplify our translations in here, and in public apps in general.

Thoughts?

/cc @maximeprades @liulikun @sandlerr @princemaple @dan753722

@maximeprades
Copy link
Contributor

well I'd tend to agree but @jwswj and I agreed that we need to show them the way to do it if they ever want to get their app localized

Let's keep the old format please...

@princemaple
Copy link
Contributor

I don't think it's a very hard thing to get value & title pairs set up.
We could just refer the developers to App Reference and let them decide which style they want to use.

@tmcinerney
Copy link
Contributor Author

Do we know how many public vs private apps are being created? It is basically us that create public apps right? So for private apps, it's not something the app developer really needs to know because they would be unlikely to internationalise their app. If the majority of apps would be private (and hence without translations), is it good to have examples of an app using something they wont use?

We can certainly document how internationalisation can be done in your en.json but it should be an optional step in my opinion. The entire value, title key pairs are stripped down to the simply implementation when the app is served in installed.js as well.

@princemaple
Copy link
Contributor

Private app authors will probably just hard code all the values in app.js or *.hdbs. 😄 like we tended to do (before being corrected)

@liulikun
Copy link

My thinking was that we have our apps documentation (developer.zendesk.com) and existing sample apps and most of our public apps (if not all) still using the normal format en.json. And I think that format serves the majority of the public audience well. If we show this new format to the general public only for a very small portion of the audience and that small portion probably know this already, the most of public people will get confused because the json file doesn't tell much what's that structure for. I can think of 3 options:

  1. Don't show this new format to general public.
  2. Show this new format to general public, but update our documentation to explain 2 different translation formats, and update our public apps and/or existing sample apps to use this new format.
  3. Only allow new translation format. This also needs to update documentation and existing apps.

I like option 1.

@maximeprades
Copy link
Contributor

Thanks guys for opening this discussion but we need to go with option 2

We have to show the "example" to our App developers, get them to understand the importance of our other markets.

Half of zendesk customers core language isn't english. We get a public app submission a week so the math is pretty simple to do

@jwswj
Copy link
Contributor

jwswj commented Dec 21, 2013

Agree that option 2 is what we need to do.

On Sat, Dec 21, 2013 at 12:02 PM, Maxime Prades notifications@github.comwrote:

Thanks guys for opening this discussion but we need to go with option 2

We have to show the "example" to our App developers, get them to
understand the importance of our other markets.

Half of zendesk customers core language isn't english. We get a public app
submission a week so the math is pretty simple to do


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-31071015
.

Jason Smale
Engineering Director - APAC

Zendesk http://www.zendesk.com/
Twitter: @jwswj | Skype: zendesk.jsmale | Phone: +61 402 073 344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants