[PRI][WIP] update the JSON format for the translation file en.json #32
Conversation
|
👍 |
| @@ -1,6 +1,54 @@ | |||
| { | |||
| "app": { | |||
| "description": "Play the famous zen tunes in your help desk.", | |||
| "name": "Buddha Machine" | |||
| "package": "basic_user_sample", | |||
There was a problem hiding this comment.
Well, from memory we use this for translation keys. This forms part of the prefix in the generated YML
There was a problem hiding this comment.
Should we add a validation that ensures people can't use this default value when packaging their app @liulikun?
There was a problem hiding this comment.
yes so we either
- don't need it here (remember our customers will see this when they run zat new)
- need to make it vanilla. like app_name
|
Can you fix the tests please @dan753722? You might need to check the test fixtures to ensure they are correct. |
|
👍 after tests are green |
|
@maximeprades @tmcinerney I'm not sure this is a good idea to use zendesk translation format as default. It'll confuse the public users. |
|
@tmcinerney CI is green now :) |
|
Closing since we don't want to complicate the process for app developers, in line with @liulikun comment. |
|
So @maximeprades, would you like this guy merged based on the other discussion? |
|
Yes sir
|
[PRI][WIP] update the JSON format for the translation file en.json
[PRI][WIP] update the JSON format for the translation file en.json
🐨👍
This PR intends to update the JSON format of the en translation file.
TASKS
@svizzari , @maximeprades, and @tmcinerney can you please review this format? I am happy to further refine it if there is any error :)
/cc @zendesk/quokka