This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Add submit banner to admin page for organizations #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roseleaf
reviewed
Nov 9, 2017
| padding: 8px 8px; | ||
| min-width: 200px; | ||
| font-size: 16px; | ||
| } |
There was a problem hiding this comment.
could use some space underneath of it
There was a problem hiding this comment.
I just added some padding in OrganizationEdit.css. Here's the new look
roseleaf
changed the title
adam-hart
force-pushed
the
ahart/add-banner
branch
from
fca3938
to
d8d33a3
Compare
roseleaf
reviewed
Nov 15, 2017
| const goodTitle = 'Success!' | ||
| const badTitle = 'Something went wrong!' | ||
|
|
||
| const formatBanner = (props) => { |
There was a problem hiding this comment.
I wonder if we should also optionally pass in the titles so they can be more specific to what succeeded or failed. Not a blocker though
There was a problem hiding this comment.
That's a good idea. It's generally more flexible that way, too. I'll add it to the scrum board though, since I'd like to ship this ASAP.
roseleaf
approved these changes
Nov 15, 2017
craig-day
pushed a commit
that referenced
this pull request
Apr 15, 2022
Add submit banner to admin page for organizations
craig-day
pushed a commit
that referenced
this pull request
Apr 15, 2022
Add submit banner to admin page for organizations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pops up a basic banner on an Organization edit page's submit.
Bueno
No Bueno
@zendesk/volunteer
Fixes #402