Make Maxwell compatible with MariaDB MaxScale #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, do these look acceptable for mainline Maxwell? The relevant changes on the MaxScale end have just been merged it looks like they will land in the next release. |
|
sorry for the lag, I've been travelling. will pull off some time to review soon. |
|
Cool, thanks 🙂 |
|
needs a test or two to exercise the case where the schema-server is different than the replication server. Otherwise looks good to merge. |
added 3 commits
February 14, 2017 11:21
MaxScale does not support subsecond heartbeats resolution.
|
Rebased and added a test case. Not sure what else to test there. |
|
looks like test failures were unrelated, kicked the build. |
|
(:+1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 logical changes in the PR, each in its own commit:
This is required when
replication_hostoption is set to MaxScale. MaxScale does not keep a copy of database schema. The commit introduces a newschema_{host,port,user,password}options that are to be configured with a location of a MySQL/MariaDB's node holding the schema.MaxScale is not capable of handling sub-second heartbeat intervals and requesting one, results (due to integer truncation) in heartbeat interval set to 0, which disables heartbeats altogether.