Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.0 compatibility #10

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Rails 6.0 compatibility #10

merged 1 commit into from
Dec 3, 2019

Conversation

zhuravel
Copy link
Contributor

@zhuravel zhuravel commented Dec 2, 2019

  • Add support for Rails 6.0
  • Drop support for Rails 3.2
  • Start testing against modern Rubies: 2.5 and 2.6.
  • Stop testing against EOL Rubies: 2.2. and 2.3.

@bquorning
Copy link
Member

A bit more context:

Rails commit rails/rails@fdf3f0b changed
ActiveRecord::Base.configurations from returning a Hash to returning an ActiveRecord::DatabaseConfigurations object.

gemfile: gemfiles/rails4.2.gemfile
- rvm: 2.6
gemfile: gemfiles/rails5.0.gemfile
- rvm: 2.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why we wouldn’t test older versions of Rails on newer versions of Ruby. I understand that testing all possible combinations may be too time consuming.

Copy link
Member

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@bquorning bquorning merged commit 1b64f99 into zendesk:master Dec 3, 2019
@bquorning
Copy link
Member

Released as v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants