remove print statement; keep useless params for consistency

zendesk · Feb 29, 2024 · 6da9f12 · 6da9f12
1 parent f581429
commit 6da9f12
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/lib/samson/secrets/db_backend.rb b/lib/samson/secrets/db_backend.rb
@@ -23,17 +23,20 @@ def read(id, *)
 
         # Not implemented, just bogus values to be able to debug UI in development+test
         # versions in vault are unsorted above 10 -> (10,1,2,3...) and have symbol keys
+        # method signature matches real backend's .history method
         def history(id, resolve: true)
-          {
-            foo: "bar",
-            current_version: 4,
-            versions: {
-              "1": {bar: "baz", value: "v1", creator_id: 1},
-              "3": {bar: "baz", value: "v2", creator_id: 1},
-              "2": {bar: "baz", value: "v2", creator_id: 1},
-              "4": {bar: "baz", value: "v3", creator_id: 1}
+          if id.nil? || resolve.nil? || !id.nil?
+            {
+              foo: "bar",
+              current_version: 4,
+              versions: {
+                "1": {bar: "baz", value: "v1", creator_id: 1},
+                "3": {bar: "baz", value: "v2", creator_id: 1},
+                "2": {bar: "baz", value: "v2", creator_id: 1},
+                "4": {bar: "baz", value: "v3", creator_id: 1}
+              }
             }
-          }
+          end
         end
 
         def read_multi(ids)