Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support githubs default www-form-encoded payload #1671

Merged
merged 1 commit into from Jan 17, 2017
Merged

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jan 17, 2017

by default a webhook is now

screen shot 2017-01-17 at 1 22 48 pm

content-type: application/x-www-form-urlencoded

which ends up with a payload looking like

screen shot 2017-01-17 at 1 24 24 pm

and blows up like NoMethodError: undefined method []' for nil:NilClass`
https://zendesk.airbrake.io/projects/95346/groups/1865431083722943737/notices/1865431075729152468?tab=notice-detail

content-type: application/x-www-form-urlencoded
@grosser grosser requested a review from irwaters January 17, 2017 21:23
@grosser grosser merged commit 949f215 into master Jan 17, 2017
@grosser grosser deleted the grosser/url branch January 17, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants