Align as_json method (use args instead of kwargs)
#4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @grosser. Could I please get your help to merge this PR as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's a change in Ruby 3.0 that separates positional and keyword arguments.
Change
Some Samson classes have the
as_jsonmethod overridden. The method definition in the Rails superclass accepts an options hash argument. However, the method definition in the subclasses is changed to accept keyword arguments instead. This inconsistency won't work on Ruby 3.In preparation for the Ruby 3.0 upgrade, align the subclass method definitions with the superclass by accepting an options hash argument instead of keyword arguments.
Considerations
This change is far from resolving all the args/kwargs issues when running on Ruby 3.0, but it's a safe start.