Upgrade rack-mini-profiler to v2.3.3 #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Feb 13, 2024
Gemfile
Outdated
| @@ -101,7 +101,7 @@ group :debugging do | |||
| end | |||
|
|
|||
| group :development, :staging do | |||
| gem 'rack-mini-profiler' | |||
| gem 'rack-mini-profiler', '~> 2.3.2' | |||
There was a problem hiding this comment.
Suggested change
| gem 'rack-mini-profiler', '~> 2.3.2' | |
| gem 'rack-mini-profiler' |
There was a problem hiding this comment.
we don't want to block future upgrades
There was a problem hiding this comment.
ok removed the guard and ran bundle update rack-mini-profiler which bumped to 3.3.0. I tested that and it seemed to work
|
ah nice I though I already had bumped that 🤦 |
|
deployed to staging https://samson.zende.sk/projects/samson/deploys/2100282 |
|
streaming deploys seems to still be broken, but this is a good step forward |
|
I will start troubleshooting that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade rack-mini-profiler to v2.3.3 to fix the ActionView::Template:Error (undefined method `safe_append=' for {:add_to_stack=>true}:Hash).
Followed the advice from here
Risks