Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading code snippets in Garden's Menu documentation #945

Closed
danielcaldas opened this issue Nov 24, 2020 · 0 comments · Fixed by #947
Closed

Misleading code snippets in Garden's Menu documentation #945

danielcaldas opened this issue Nov 24, 2020 · 0 comments · Fixed by #947

Comments

@danielcaldas
Copy link

Expectations

Documentation should be hasArrow instead of arrow.

Reality

Currently under the documentation page we have the prop arrow instead of hasArrow in the example snippets, which is misleading.

<Menu placement="end" arrow>
  <Item value="option-1">Option 1</Item>
  <Item value="option-2">Option 2</Item>
  <Item value="option-3">Option 3</Item>
</Menu>

Steps to Reproduce

Go to [1] or [2] where there's usage examples.

Fine Print

  • Component: Menu from '@zendeskgarden/react-dropdowns'
  • Version: ^8.25.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant