Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): support terminal-based editors for changelog step in tag sequence #749

Merged
merged 2 commits into from
May 15, 2020
Merged

fix(scripts): support terminal-based editors for changelog step in tag sequence #749

merged 2 commits into from
May 15, 2020

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 14, 2020

Description

Editor execution needs to inherit stdio from parent process.

Detail

Tested with vim as editor.

@jzempel jzempel requested a review from a team as a code owner May 14, 2020 23:49
@zendesk-garden zendesk-garden temporarily deployed to staging May 15, 2020 00:21 Inactive
@jzempel jzempel merged commit 0688f1b into master May 15, 2020
@jzempel jzempel deleted the jzempel/fix-changelog branch May 15, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingreendev austingreendev austingreendev approved these changes

Assignees
No one assigned
Labels
PR: Internal 🌱
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzempel @austingreendev @zendesk-garden