Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): support terminal-based editors for changelog step in tag sequence #749

Merged
merged 2 commits into from
May 15, 2020
Merged

fix(scripts): support terminal-based editors for changelog step in tag sequence #749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427290b
Fix for in-terminal editor (vi, for example)
jzempel May 14, 2020
5f8cb1b
Remove try..finally
jzempel May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion utils/scripts/tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ const changelog = async (tag, spinner) => {
const editor = await execa('git', ['var', 'GIT_EDITOR']);

await write(fd, markdown);
await execa.command(`${editor.stdout} ${path}`);
spinner.stop();
await execa.command(`${editor.stdout} ${path}`, { stdio: 'inherit' });
spinner.start();

const readFile = util.promisify(fs.readFile);
const INSERTION_SLUG = '<!-- insert-new-changelog-here -->';
Expand Down