List of repositories from Github

[gianarb]

Hi! This proposal is not a resolution of all problems but in this moment I think that there are only one target..
We make zf.modules usable..
Login, submit repos in the first step.. This proposal tries to "resolve" the rate limit problem.

See

• Strategies to avoid hitting the rate limit? #349

With this PR the list of repos is inconsistente because there are a lot of repos wrong (not zf2 modules).. But works and if you try to submit a wrong repo exists a check for that 😄

Now there are already problem if i try to submit a good module I have this expection
Statement could not be executed (23000 - 1048 - Column 'module_id' cannot be null)

But I don't remember the story of the module_id 📆

This isn't the final resolution :)

[adamlundrigan]

Are you working on this? I'm about to dig into #352 ([WIP] [RFC] Implement Packagist-style module add process) but I don't want to waste my time if someone else is already doing it

[gianarb]

Hi.. This is only another proposal to fix the problem.. This is very easy.. I don't know.. :) No problem for me I close this PR..

[gianarb]

Hi! I reopen this PR because in my opinion this is a good hotfix to resolve (in a first moment) the Module Load problem.. :)

When the @adamlundrigan feature well be ready we can replace it with new flow! :)

Thanks for your work!

[ins0]

@gianarb needs a rebase 😃

[gianarb]

Ready! :) Thanks @ins0..

Now into "My Modules" step return all my repositories and if you try to load a $repository->isModule() == false return exception..

[ins0]

@gianarb if the check is removed from the list will the repository still checked on the register process?

// edit never mind it does 👍

[gianarb]

Yes in this moment this check (isModule) run for each repositories when we call list and after submit the single module..

In this PR I remove the first check.. The list comprises all my repositories (not only module) but works :)

[localheinz]

@Ocramius

Hang on, I missed something!

[localheinz]

@gianarb

Looks good to me in order mitigate the API rate limit problem for now, since we still have the check when adding modules, see right here:

• ZfModule\Controller\IndexController::addAction

@Ocramius

Care to review?

[Ocramius]

Is this mock actually needed?

[localheinz]

@Ocramius

Only to assert that ZfModule\Service\Module::isModule() is never called!

[Ocramius]

Yeah, but that's not critical to this particular test, so it should just be skipped

[localheinz]

@Ocramius

The only thing we've got at the moment is a not-so-user-friendly handling of when you're trying to submit a non-module: an exception is thrown.

However, @ins0 is working on that at the moment.

[gianarb]

Yes in my opinion this is only a first fix, maybe in the future we can implement #352

[gianarb]

@Ocramius @localheinz have you news about this PR?
Works? It will merge after #421?

[localheinz]

@Ocramius

I think this can go in - but since I contributed here, I'd prefer you to have a look and merge!

[Ocramius]

It is a go indeed