[WIP] Feature: Flash Messenger Error Messages #421

ins0 · 2015-02-24T13:41:59Z

This PR

Replaces the generic error exceptions with specific exception constructors
Extend the exceptions with a public message
Covers all flashmessenger messages in a clean bs message format
Covers the error view in a clean bs message format + added public messages from exceptions
Covers the 404 error in a clean bs message format

Ocramius · 2015-02-24T17:11:03Z

module/Application/src/Application/View/Helper/FlashMessenger.php

+    {
+        $this->classOptions = [
+            PluginFlashMessenger::NAMESPACE_INFO => [
+                'name' => $this->getTranslator()->translate('Information'),


Lots of translate calls that aren't actually needed

Also, avoid calling getTranslator everywhere

@Ocramius should i avoid using translate in order that at some point the site gets multi language or calling the translator once into a var and translate it into the loop?

ins0 · 2015-02-25T10:05:47Z

@Ocramius would be nice if you could review this like meat through a meat chipper 🍖

// or everyone else of course :)

Ocramius · 2015-02-25T11:02:50Z

module/Application/src/Application/View/Helper/FlashMessenger.php

+            $messageClasses = [
+                $namespace => $this->classOptions[PluginFlashMessenger::NAMESPACE_DEFAULT],
+            ];
+        } else {


Avoid this else: do this assign operation earlier

Ocramius · 2015-02-25T11:09:48Z

@ins0 done

Ocramius · 2015-02-25T11:12:04Z

module/Application/src/Application/View/Helper/FlashMessenger.php

+
+class FlashMessenger extends ZendFlashMessenger
+{
+    /** @var array */


string[][]

ins0 · 2015-02-25T19:45:12Z

thanks @Ocramius for your first review, changed most of the suggestions - others waiting for reply 😸

Ocramius · 2015-02-27T20:50:06Z

module/ZfModule/src/ZfModule/Controller/IndexController.php

@@ -211,7 +208,8 @@ public function removeAction()

        $request = $this->getRequest();
        if (!$request->isPost()) {
-            throw new Exception\UnexpectedValueException('Something went wrong with the post values of the request...');


throw InvalidRequestDataException::fromInvalidPostRequest($request)

ins0 · 2015-03-08T15:50:24Z

@Ocramius may take the final look over this, please? 😃

localheinz · 2015-03-09T19:06:51Z

module/Application/src/Application/Exception/ViewableUserException.php

+    private $publicMessage;
+
+    /**
+     * @inheritdoc


@ins0

Here!

yeah will fix this

ins0 · 2015-03-14T12:57:33Z

ping @Ocramius :)

Ocramius · 2015-03-14T21:44:16Z

👍

[WIP] Feature: Flash Messenger Error Messages

ins0 · 2015-03-14T21:48:28Z

thanks @Ocramius @localheinz 👍

ins0 force-pushed the feature/error-messages branch from 6b7a105 to 7b97bc8 Compare February 24, 2015 15:30

Ocramius reviewed Feb 24, 2015
View reviewed changes

Ocramius reviewed Feb 25, 2015
View reviewed changes

gianarb mentioned this pull request Feb 25, 2015

List of repositories from Github #353

Merged

ins0 force-pushed the feature/error-messages branch from e4c616a to 61ebb03 Compare February 27, 2015 20:37

Ocramius reviewed Feb 27, 2015
View reviewed changes

Marco Rieger added 19 commits March 6, 2015 14:47

custom namespace falls to default message

3cebdeb

cs fixes

fd4b0b7

iterate through classOptions

46e1597

moved translation inside the loop

1578993

added integration test

6ec411e

reflect changes to existing test classes

8b38e8c

added exception tests

bdf0302

added exception classes

6c0ef62

added error template returns public error message

3c8ac55

added methods now thow new exceptions

e10625d

cs fixes

b712894

added callable renderer

99df2f5

added correct inline comment + test current messages

787abec

cs fixes

036ef32

update composer

4db579b

added covers annotation

f60753a

added interface + make private var

d8199a5

classes now final - added return self

c3284a8

renamed method

b7676ff

ins0 force-pushed the feature/error-messages branch from 85a59be to b7676ff Compare March 6, 2015 13:48

added 404 error message in bs format

203098f

localheinz reviewed Mar 9, 2015
View reviewed changes

added correct inheritdoc with brackets

daf648d

Ocramius added a commit that referenced this pull request Mar 14, 2015

Merge pull request #421 from ins0/feature/error-messages

80e336d

[WIP] Feature: Flash Messenger Error Messages

Ocramius merged commit 80e336d into zendframework:master Mar 14, 2015

ins0 deleted the feature/error-messages branch March 14, 2015 21:48

[WIP] Feature: Flash Messenger Error Messages #421

[WIP] Feature: Flash Messenger Error Messages #421

Uh oh!

Conversation

ins0 commented Feb 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ins0 commented Feb 25, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ocramius commented Feb 25, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ins0 commented Feb 25, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ins0 commented Mar 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ins0 commented Mar 14, 2015

Uh oh!

Ocramius commented Mar 14, 2015

Uh oh!

ins0 commented Mar 14, 2015

Uh oh!

Uh oh!