This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Use FQFN #50
Merged
Use FQFN #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The same we have done in zendframework/zend-servicemanager#198 but a bit different way - we import all functions on top. I would prefer that way, because we just add new lines and we don't need to modify anything else. Please note I have wrote sniff in zend-coding-standard which do it automatically ;-)
|
@webimpress Is it an "official" way to do that in zf? |
|
Hm... I just only know that we have done this way in zend-code: |
Simplifies diff, and makes it more clear exactly which internals we are using.
weierophinney
added a commit
that referenced
this pull request
Apr 24, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 24, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 24, 2018
Forward port #50 Conflicts: CHANGELOG.md
|
Thanks, @snapshotpl! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository use many internal php function. For example in my application when I use
Zend\Crypt\BlockCipherclasshash_hmacfunction is call 10k times and take ~23ms! This change should have perfomance visible impact