Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Import PHP internal functions #121

Closed
wants to merge 2 commits into from
Closed

Import PHP internal functions #121

wants to merge 2 commits into from

Conversation

michalbundyra
Copy link
Member

No description provided.

@Ocramius
Copy link
Member

Ocramius commented Jul 9, 2017

@webimpress just a note: while zend-servicemanager is a performance-sensitive component, this one is not. Not sure if worth pursuing performance improvements here.

@michalbundyra
Copy link
Member Author

@Ocramius thanks for that note. I thought you'd like to have it as a standard now, this is why I wrote the sniff. But we can have disabled it by default and just enable in performance-sensitive components

@Ocramius Ocramius self-assigned this Jul 23, 2017
@Ocramius Ocramius added this to the 3.2.0 milestone Jul 23, 2017
@Ocramius
Copy link
Member

Merging it for now - it's still a decent improvement, and you put quite some effort in it :-)

Ocramius added a commit that referenced this pull request Jul 23, 2017
@Ocramius
Copy link
Member

Merged manually to develop via 1dd0230. Thanks @webimpress!

@mikeSimonson
Copy link
Contributor

@webimpress What is the tool that you used to generate this ?

@michalbundyra
Copy link
Member Author

@mikeSimonson
It is going to be a part of new zend-coding-standard. You can find the sniff in my PR:
https://github.com/zendframework/zend-coding-standard/pull/1/files#diff-02ee2a3197d92d5f724d0d7dffc13ac0

I still need to work on it, but when you check out the branch you can use that sniff separately.
I have plan to work on sniffs this week, and hopefully finish it till end of this year ! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants