-
Notifications
You must be signed in to change notification settings - Fork 84
Add status codes: 226, 308, 444, 499, 510, 599 #110
Conversation
src/Response.php
Outdated
@@ -101,6 +107,7 @@ class Response extends AbstractMessage implements ResponseInterface | |||
206 => 'Partial Content', | |||
207 => 'Multi-status', | |||
208 => 'Already Reported', | |||
226 => 'IM used', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RFC 3229 defines it as IM Used
, not IM used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -138,7 +146,9 @@ class Response extends AbstractMessage implements ResponseInterface | |||
428 => 'Precondition Required', | |||
429 => 'Too Many Requests', | |||
431 => 'Request Header Fields Too Large', | |||
444 => 'Connection Closed Without Response', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#nginx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists in diactoros/response
451 => 'Unavailable For Legal Reasons', | ||
499 => 'Client Closed Request', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#nginx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists in diactoros/response
511 => 'Network Authentication Required', | ||
599 => 'Network Connect Timeout Error', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#Unofficial_codes
use iana instead, as proposed in zend\diactoros latest pr at diacoros |
Additional headers are supported by some common web servers. At the same time IANA changes do not happen often and should some be officially assigned we can safely change reason phrase at a later time. |
@Xerkus is there any plan for 2.7.0 release for it ? thank you. |
is there any chance for 2.7.0 release for it ? thank you. |
@Xerkus is there any chance for 2.7.0 release for it ? thank you. |
@samsonasik Sorry, drowned in notifications. I thought i did release it months ago. |
@Xerkus thank you ;) |
No description provided.