Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add status codes: 226, 308, 444, 499, 510, 599 #110

Merged
merged 2 commits into from
Mar 2, 2017

Conversation

samsonasik
Copy link
Contributor

No description provided.

src/Response.php Outdated
@@ -101,6 +107,7 @@ class Response extends AbstractMessage implements ResponseInterface
206 => 'Partial Content',
207 => 'Multi-status',
208 => 'Already Reported',
226 => 'IM used',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC 3229 defines it as IM Used, not IM used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlocati fixed at 77b16e2 , Thanks ;)

@@ -138,7 +146,9 @@ class Response extends AbstractMessage implements ResponseInterface
428 => 'Precondition Required',
429 => 'Too Many Requests',
431 => 'Request Header Fields Too Large',
444 => 'Connection Closed Without Response',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#nginx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exists in diactoros/response

451 => 'Unavailable For Legal Reasons',
499 => 'Client Closed Request',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#nginx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exists in diactoros/response

511 => 'Network Authentication Required',
599 => 'Network Connect Timeout Error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to be "official"? Not sure what the stance is on this.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#Unofficial_codes

@samsonasik
Copy link
Contributor Author

use iana instead, as proposed in zend\diactoros latest pr at diacoros

@Xerkus Xerkus self-assigned this Mar 2, 2017
@Xerkus
Copy link
Member

Xerkus commented Mar 2, 2017

Additional headers are supported by some common web servers. At the same time IANA changes do not happen often and should some be officially assigned we can safely change reason phrase at a later time.

@Xerkus Xerkus merged commit 77b16e2 into zendframework:develop Mar 2, 2017
Xerkus added a commit that referenced this pull request Mar 2, 2017
Xerkus added a commit that referenced this pull request Mar 2, 2017
@samsonasik samsonasik deleted the add-status-codes branch March 3, 2017 03:56
@Xerkus Xerkus added this to the 2.7.0 milestone Mar 6, 2017
@samsonasik
Copy link
Contributor Author

@Xerkus is there any plan for 2.7.0 release for it ? thank you.

@samsonasik
Copy link
Contributor Author

is there any chance for 2.7.0 release for it ? thank you.

@samsonasik
Copy link
Contributor Author

@Xerkus is there any chance for 2.7.0 release for it ? thank you.

@Xerkus
Copy link
Member

Xerkus commented Oct 13, 2017

@samsonasik Sorry, drowned in notifications. I thought i did release it months ago.

@samsonasik
Copy link
Contributor Author

@Xerkus thank you ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants