Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in Safari #204

Closed
garyking opened this issue Sep 1, 2016 · 10 comments
Closed

Does not work in Safari #204

garyking opened this issue Sep 1, 2016 · 10 comments

Comments

@garyking
Copy link
Contributor

garyking commented Sep 1, 2016

The app isn't working on iPhone in Safari, Firefox, and Chrome. Just stuck on the loading screen.

@dumbmatter
Copy link
Member

dumbmatter commented Sep 1, 2016

This is due to https://github.com/dfahlander/Dexie.js/wiki/IndexedDB-on-Safari/f0b78c65a43742d6bfde898769ceb76b33db5337 - iOS 10 might fix it, I haven't tried yet. Same thing with Safari 10 on OS X. I don't have any Apple devices, so if anyone does, some testing (and debugging if it still doesn't work) would be appreciated.

@dumbmatter dumbmatter changed the title Not working on iPhone, any browser Does not work in Safari Sep 23, 2016
@dumbmatter
Copy link
Member

I did some testing in Safari 10. Two issues so far:

  1. It doesn't like it when you start a transaction with no mode, it needs you to explicitly specify. I fixed this in dumbmatter/backboard@86a9235
  2. Indexes are fucked up, see my bitching at https://www.reddit.com/r/javascript/comments/545ylm/psa_indexeddb_on_safari_10_is_still_shitty/ - hopefully an update to Safari 10 will fix that bug. Until then, I don't think it's worth it trying to hack around it. Instead, I'll try to add detection of this bug and show an error message.

@mitchellhenke
Copy link

The newest iOS 10.3 release appears to have a functional IndexedDB and I'm able to play.

@dumbmatter
Copy link
Member

Awesome, thanks for the info!

@dumbmatter
Copy link
Member

Three things happened recently:

  1. I started working on Basketball GM 4.0, which fixes gameplay in Safari 10.0.3
  2. Safari 10.1 was released, which started working with Basketball GM 3.6
  3. Safari 10.1 also seems to have broken Basketball GM 4.0 somehow (I've only tested on iPhone, so debugging is hard)

So... this bug is still open I think.

@dumbmatter dumbmatter reopened this Apr 1, 2017
@battaile
Copy link
Contributor

battaile commented Apr 1, 2017

Yeah, Safari 10.1 crashes on my mac:
https://gist.github.com/battaile/abe7be0cf3f3d406b43f3e66ed4bd8c3

@dumbmatter
Copy link
Member

I fucking hate Safari. Can you try https://www.lifewire.com/reporting-safari-defects-to-apple-446584 and report the bug to them?

@battaile
Copy link
Contributor

battaile commented Apr 1, 2017

Looks like they just get sent automatically in 10.1, and that menu option doesn't exist anymore
http://i.imgur.com/9nH6eFL.png

@dumbmatter
Copy link
Member

I finally got around to debugging this and managed to find the Safari bug and work around it.

@beidson I've seen other people tag you about Safari IndexedDB bugs, so you might like to know that Safari 10.1 crashes when you use getAll in a Web Worker. I submitted a bug report: https://bugs.webkit.org/show_bug.cgi?id=172434

@beidson
Copy link

beidson commented May 22, 2017

Thanks for the report, following up over in the bugzilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants